Fix regex parsing of lease file mixing up lease entries#90
Conversation
|
Was done once in the past here #52 but closed with the hope of migrating to kea. Another option would be IMHO to integrate a dhcp server into metal-bmc, for example with the help of https://github.com/coredhcp/coredhcp. With this approach we would not have to parse anything and deployment could be potentially easier. |
|
I am not sure who should drive the kea migration. I would be better for sure but we have so many topics to work that I am not sure if we can do it. Integrating the DHCP server into metal-bmc would mean that we cannot put the dhcp server and metal-bmc in different locations anymore, which might be an issue for some setups. |
Agreed with both |
Description
The regex is erroneous and potentially dangerous. Sometimes the isc-dhcp-server can produce lease entries with a
hardware ethernetline. For example:The regex then parses in a lease with IP
10.0.0.129and mac address00:00:00:00:00:01. Potential lease entries between are dropped. The association is broken.