Skip to content

log error if lldp discovery fails #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iljarotar merged 3 commits into from
Dec 2, 2025
Merged

log error if lldp discovery fails #175

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
deccb39
log error if lldp discovery fails
iljarotar Dec 2, 2025
02518da
linter
iljarotar Dec 2, 2025
523a323
Merge branch 'master' of github.com:metal-stack/metal-core into log-l…
iljarotar Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions cmd/internal/core/phone-home.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,13 @@ func (c *Core) ConstantlyPhoneHome(ctx context.Context, interval time.Duration)

ifaceName := iface.Name
// constantly observe LLDP traffic on current machine and current interface
discoveryResultChanWG.Add(1)
go func() {
discoveryResultChanWG.Go(func() {
defer discoveryResultChanWG.Done()
err = lldpcli.Start(c.log, discoveryResultChan)
if err != nil {
c.log.Error("unable to start lldp discovery for interface", "interface", ifaceName)
c.log.Error("unable to start lldp discovery for interface", "interface", ifaceName, "error", err)
}
}()
})
}

// wait all lldp routines to finish to close result channel
Expand Down Expand Up @@ -81,7 +80,7 @@ func (c *Core) ConstantlyPhoneHome(ctx context.Context, interval time.Duration)
select {
case <-ticker.C:
msgs := []phoneHomeMessage{}
phoneHomeMessages.Range(func(key, value interface{}) bool {
phoneHomeMessages.Range(func(key, value any) bool {
msg, ok := value.(phoneHomeMessage)
if !ok {
return true
Expand Down