Skip to content

Comments

Fix waitgroup panics with negative counter#179

Merged
majst01 merged 1 commit intomasterfrom
fix-waitgroup-panic
Jan 21, 2026
Merged

Fix waitgroup panics with negative counter#179
majst01 merged 1 commit intomasterfrom
fix-waitgroup-panic

Conversation

@majst01
Copy link
Contributor

@majst01 majst01 commented Jan 20, 2026

Description

Closes #178

@majst01 majst01 requested a review from iljarotar January 20, 2026 10:41
@majst01 majst01 self-assigned this Jan 20, 2026
@majst01 majst01 requested a review from a team as a code owner January 20, 2026 10:41
@majst01 majst01 force-pushed the fix-waitgroup-panic branch from d902bbd to 91104e6 Compare January 20, 2026 12:57
@majst01 majst01 force-pushed the fix-waitgroup-panic branch from 91104e6 to 10ca7ea Compare January 20, 2026 13:18
ifaceName := iface.Name
// constantly observe LLDP traffic on current machine and current interface
discoveryResultChanWG.Go(func() {
defer discoveryResultChanWG.Done()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually the root cause of negative counter values.

@majst01 majst01 merged commit 6663b23 into master Jan 21, 2026
1 check passed
@majst01 majst01 deleted the fix-waitgroup-panic branch January 21, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

negative WaitGroup counter when stopping metal-core

2 participants