add oci pull to images #175
Conversation
|
@majst01 okay, so this is what I came up with. Can you do a review, pls? Besides, I'm wondering if it's suitable to retrieve the oci credentials from env vars. Can you help me out here? |
The OCI creadentials should be passed as optional fields from the pixiecore to the metal-hammer: https://github.com/metal-stack/metal-hammer/blob/master/cmd/pixie-client.go#L14 Ideally a slice of registryconfig which contains the registry url, the username and the password should come from pixiecore. |
|
@majst01 does this work? https://github.com/metal-stack/metal-hammer/pull/175/files#diff-cfcd5a78ad9476ee24d7680dd023e71136f329c771d76ae6837ba68320b6379cR37 what does |
It contains the full URL as configured in the image |
mac641
force-pushed
the
oci-puller
branch
3 times, most recently
from
0bfe689 to
7052ccb
Compare
machine.Allocation.Image.URL can be used without auth
since it's not supported by name.ParseReference
…nd default to image
mac641
force-pushed
the
oci-puller
branch
7 times, most recently
from
ad2bb15 to
2506148
Compare
mac641
force-pushed
the
oci-puller
branch
7 times, most recently
from
7b7365d to
2a95918
Compare
| for _, c := range ociConfigs { | ||
| err = img.NewImage(h.log).OciPull(ctx, c.RegistryURL, h.chrootPrefix, c.Username, c.Password) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } |
There was a problem hiding this comment.
The ociconfig should be a map from registry -> credentials, then you can simple get the credentials required for this registry and no need to iterate
| // keep this until https://github.com/u-root/u-root/pull/3451 is merged and released | ||
| github.com/u-root/u-root => github.com/majst01/u-root v0.0.0-20250910091544-306665b6f8e8 | ||
|
|
||
| google.golang.org/genproto => google.golang.org/genproto v0.0.0-20250826171959-ef028d996bc1 |
There was a problem hiding this comment.
I had an import cycle which was fixed by this. If you have any idea on how to solve this differently, I'm happy to implement it.
Description
References
TODO