Skip to content

Apply yaml fixes from ansible-lint.#531

Open
Gerrit91 wants to merge 3 commits intomasterfrom
yaml-fixes
Open

Apply yaml fixes from ansible-lint.#531
Gerrit91 wants to merge 3 commits intomasterfrom
yaml-fixes

Conversation

@Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Feb 16, 2026

Description

I used --fix yaml from ansible-lint for this.

@metal-robot metal-robot bot added the area: deployment Affects the deployment area. label Feb 16, 2026
copy:
dest: "{{ metal_core_grpc_cert_dir }}/{{ item.filename }}"
mode: 0640
mode: "0640"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs verification

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:

root@leaf02:~# ls -alh /certs/grpc  
total 20K
drwxr-xr-x 2 root root 4.0K Feb 16 14:30 .
drwxr-xr-x 3 root root 4.0K Feb 16 14:30 ..
-rw-r----- 1 root root 2.0K Feb 16 14:30 ca.pem
-rw-r----- 1 root root 3.2K Feb 16 14:30 client-key.pem
-rw-r----- 1 root root 2.1K Feb 16 14:30 client.pem

- name: Get metal-apiserver pods
set_fact:
_metal_apiserver_pod: "{{ (lookup('k8s', api_version='v1', kind='Pod', namespace=metal_control_plane_namespace, label_selector='app=metal-apiserver') | list_wrap)[0].get('metadata', {}).get('name') }}"
_metal_apiserver_pod: "{{ (lookup('k8s', api_version='v1', kind='Pod', namespace=metal_control_plane_namespace, label_selector='app=metal-apiserver') | list_wrap)[0].get('metadata',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just hope that these kind of line breaks work. 😅

@@ -1,3 +1,4 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also think about excluding the .github directory, but I don't really mind.

@Gerrit91 Gerrit91 marked this pull request as ready for review February 16, 2026 13:32
@Gerrit91 Gerrit91 requested a review from a team as a code owner February 16, 2026 13:32
@Gerrit91 Gerrit91 requested a review from simcod February 16, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: deployment Affects the deployment area.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant