Add tip to speed up release process to releasing doc#596
Add tip to speed up release process to releasing doc#596Sunnatillo wants to merge 1 commit intometal3-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tuminoid
left a comment
There was a problem hiding this comment.
This is already part of each repositorys docs/releasing.md, not sure if it needs to be duplicated here?
|
I don't see the benefit as its a pre-check for before cutting anything, same as this doc,, but if you feel this benefits someone, then lets merge it. |
Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
bde8b1a to
16963c8
Compare
|
New changes are detected. LGTM label has been removed. |
| High-level release process for a major/minor release. For patch releases, only | ||
| release the relevant versions. | ||
|
|
||
| **TIP**: To speed up the release process, run the `hack/verify-release.sh` |
There was a problem hiding this comment.
The more you edit this, the more I dislike it. The point of verify-release.sh is to make sure something wasn't missed. Its not supposed to be "part" of release process to bump the CVEs etc. All those should've happened as part of normal development process, and the script is just safeguard for verification of that work.
There was a problem hiding this comment.
This paragraph is giving the same idea as here:
https://github.com/metal3-io/baremetal-operator/blob/230a562f7e3b09299f60fc4c9c684b0210707149/docs/releasing.md?plain=1#L18
I have updated slightly to clarify my point about speeding up the process. |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
smoshiur1237
left a comment
There was a problem hiding this comment.
We always need to go through release doc from each repo and there it mentioned to run the verify script, I can't foresee any benefits or need of this part. I think we are good without this tip..
This PR adds tip to speed up release process to releasing doc.
Fixing issues identified with hack/verify-release.sh script would really speed up release process.