Skip to content

Comments

docs(design): improve failure domain example scenario in fd-support-kcp#659

Open
shibaPuppy wants to merge 1 commit intometal3-io:mainfrom
shibaPuppy:main
Open

docs(design): improve failure domain example scenario in fd-support-kcp#659
shibaPuppy wants to merge 1 commit intometal3-io:mainfrom
shibaPuppy:main

Conversation

@shibaPuppy
Copy link
Contributor

Improves the example scenario in the failure domain design doc to use concrete rack names instead of abstract identifiers.

also serves as a design document proposing how CAPM3 should support failure domains with Kubeadm Control Plane (KCP).

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot
Copy link
Contributor

Hi @shibaPuppy. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 23, 2026
@shibaPuppy shibaPuppy force-pushed the main branch 3 times, most recently from 153164c to c399be8 Compare February 23, 2026 01:25
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2026
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the linter failures.

IMO it looks a bit too verbose, but not expert on this.
/cc @Sunnatillo @Rozzii
PTAL

@shibaPuppy
Copy link
Contributor Author

I also split the DataTemplate selection proposal into a separate file fd-datatemplate-selection.md to keep fd-support-kcp.md focused on the original BMH selection design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants