docs(design): improve failure domain example scenario in fd-support-kcp#659
docs(design): improve failure domain example scenario in fd-support-kcp#659shibaPuppy wants to merge 1 commit intometal3-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @shibaPuppy. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
153164c to
c399be8
Compare
|
/ok-to-test |
tuminoid
left a comment
There was a problem hiding this comment.
Address the linter failures.
IMO it looks a bit too verbose, but not expert on this.
/cc @Sunnatillo @Rozzii
PTAL
Signed-off-by: shibaPuppy <sub951@naver.com>
|
I also split the DataTemplate selection proposal into a separate file |
Improves the example scenario in the failure domain design doc to use concrete rack names instead of abstract identifiers.
also serves as a design document proposing how CAPM3 should support failure domains with Kubeadm Control Plane (KCP).