[storefront] feature: custom pricing for saleable item attributes#30
Merged
metalalive merged 3 commits intomasterfrom Feb 4, 2025
Merged
Conversation
- from now on, there is only one product, saleable item, no package exists - remove product-type field from web endpoint and model schema - for price adjustment between different combination of saleable items, consider coupon feature (TODO) Signed-off-by: T.H. <7197142+metalalive@users.noreply.github.com>
- new columns for mapping specific attribute value to extra change amount to `StoreProductAvailable` - TODO, refactor model `StoreProductAvailable`, provide translation functions between the model and `EditProductReqBody` - note SQLAlchemy checks row count affected by default for update statement, and database backend may skip the update if it finds the updating row is as the same as the persisted row, this happenes to mariaDB in case of string columns like `VARCHAR` or `LONGTEXT`, such mechanism may cause row count mismatch between actual updated rows and expected-to-update rows. - the new content to update is checked in app sevrer before constructing update statement , in order to avoid the issue above Signed-off-by: T.H. <7197142+metalalive@users.noreply.github.com>
Signed-off-by: T.H. <7197142+metalalive@users.noreply.github.com>
metalalive
added a commit
that referenced
this pull request
Feb 11, 2025
agiledev624
added a commit
to agiledev624/ecommerce-backend
that referenced
this pull request
Jul 17, 2025
- remove them at model, usecase, adapter layers - this project no longer supports product type , see relevant change in [PR31](metalalive/e_commerce#31) and [PR30](metalalive/e_commerce#30)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: remove needless product type