Skip to content

Spellcheck#4867

Merged
wlammen merged 3 commits intometamath:developfrom
tirix:spellcheck
Jun 4, 2025
Merged

Spellcheck#4867
wlammen merged 3 commits intometamath:developfrom
tirix:spellcheck

Conversation

@tirix
Copy link
Copy Markdown
Contributor

@tirix tirix commented Jun 1, 2025

This corrects several spelling mistakes in the comments of set.mm.

Seeing how many mistakes I make in my own PRs, I have made a few modifications to metamath-knife to add a spell checker for theorem comments and section headers (PR to come).

These changes are the result of findings after running it on set.mm.

The dictionary I used is missing several technical mathematical words (and a few non-words, like setvar, wff or mmj2), maybe a new $j command could be used to extend it.

We also tend to use a lot of latin terms (like modus ponens), I would recommend to italicize them so that they are skipped in the spell checking (this does not apply to words like e.g. definiens, which is a valid english word)

@tirix
Copy link
Copy Markdown
Contributor Author

tirix commented Jun 1, 2025

See metamath-knife#186 for the changes in metamath-knife, and more about the method used.

@tirix tirix requested a review from wlammen June 1, 2025 17:17
Copy link
Copy Markdown
Contributor

@avekens avekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I also was astonished how many typos (even by me!) were in set.mm.

@tirix
Copy link
Copy Markdown
Contributor Author

tirix commented Jun 2, 2025

Great, I also was astonished how many typos (even by me!) were in set.mm.

This is probably not exhaustive, it was the result of a quick first pass.
The dictionary I checked against is not exhaustive, so I had a lot of false positive with complex math terms (e.g pseudograph), but there were also e.g. foreign words, and commented out proofs, which also lead to errors I had to prune out.

@wlammen wlammen merged commit f946cb4 into metamath:develop Jun 4, 2025
10 checks passed
@jkingdon
Copy link
Copy Markdown
Contributor

We also tend to use a lot of latin terms (like modus ponens), I would recommend to italicize them so that they are skipped in the spell checking

I guess italics make sense but are these really common or is it more of a handful of occasions?

Sorry to go down a tangent but this prompted me to look at our use of tertium non datur, which is mentioned once but elsewhere we say "excluded middle" (or "law of the excluded middle"), following general usage these days. Actually, going even further down the tangent, tertium non datur isn't a very good name at least in iset.mm because of https://us.metamath.org/ileuni/pwtrufal.html and in fact the section of [Bauer] cited there discusses the point even translating tertium non datur into English as "law of excluded third".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants