feat(setup): support using system CMake#188
Merged
XuehaiPan merged 4 commits intometaopt:mainfrom Feb 12, 2025
Merged
Conversation
Add the dependency on PyPI `cmake` package only when the system tool is not available, and use it otherwise. This avoids an unnecessary dependency on a third-party binary package, and improves portability by letting users benefit from downstream patching.
Contributor
Author
|
For the record, |
XuehaiPan
approved these changes
Feb 10, 2025
Member
XuehaiPan
left a comment
There was a problem hiding this comment.
It generally looks good. I have tested it locally, and it works as expected.
I have raised a discussion in the original issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 3786 3786
=========================================
Hits 3786 3786
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
Hi @mgorny, I tweaked some of the changes in this PR. Let me know if you are fine with the changes. Then we can get this merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the dependency on PyPI
cmakepackage only when the system tool is not available, and use it otherwise.Motivation and Context
This avoids an unnecessary dependency on a third-party binary package, and improves portability by letting users benefit from downstream patching.
close #187
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)