-
Notifications
You must be signed in to change notification settings - Fork 21
update json schema #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Summary by CodeRabbit
WalkthroughThe API specification was updated from version 1.1.0 to 1.1.1. Several new optional properties were added to the asset-related schemas, including Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
♻️ Duplicate comments (4)
specification/metaplex-das-api.json (4)
862-897
: Duplicate schema segment – see earlier compression feedback
924-925
: Duplicatecategory
schema – see earlier comment
1124-1125
: Duplicate enum extension – see earlier comment
1185-1190
: Duplicatenon_transferable
schema – see earlier comment
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
specification/metaplex-das-api.json
(37 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: MarkSackerberg
PR: metaplex-foundation/digital-asset-standard-api#22
File: clients/js/test/getAssetSignatures.test.ts:5-40
Timestamp: 2025-04-22T10:35:39.080Z
Learning: As part of PR #22 in the metaplex-foundation/digital-asset-standard-api repository, the `getAssetSignatures` function was updated to no longer use `getAssetSignaturesV2`, making it compatible with all DAS API endpoints, not just Aura. The implementation now follows the object-based RPC call pattern like other methods.
Learnt from: MarkSackerberg
PR: metaplex-foundation/digital-asset-standard-api#22
File: clients/js/test/getAssetProofs.test.ts:16-16
Timestamp: 2025-04-22T09:44:46.042Z
Learning: For the PR transitioning from position/array-based RPC calls to object-based RPC calls in the digital-asset-standard-api, methods with only one parameter (like `getAssetProofs`) can remain using the direct parameter style rather than being converted to object-based.
Learnt from: MarkSackerberg
PR: metaplex-foundation/digital-asset-standard-api#15
File: clients/js/src/decorator.ts:245-282
Timestamp: 2025-04-02T09:23:07.217Z
Learning: The parameter structure in the Digital Asset Standard API is intentionally aligned with "aura" for compatibility reasons, so suggestions to change the parameter structure should be avoided.
📚 Learning: as part of pr #22 in the metaplex-foundation/digital-asset-standard-api repository, the `getassetsig...
Learnt from: MarkSackerberg
PR: metaplex-foundation/digital-asset-standard-api#22
File: clients/js/test/getAssetSignatures.test.ts:5-40
Timestamp: 2025-04-22T10:35:39.080Z
Learning: As part of PR #22 in the metaplex-foundation/digital-asset-standard-api repository, the `getAssetSignatures` function was updated to no longer use `getAssetSignaturesV2`, making it compatible with all DAS API endpoints, not just Aura. The implementation now follows the object-based RPC call pattern like other methods.
Applied to files:
specification/metaplex-das-api.json
📚 Learning: for the pr transitioning from position/array-based rpc calls to object-based rpc calls in the digita...
Learnt from: MarkSackerberg
PR: metaplex-foundation/digital-asset-standard-api#22
File: clients/js/test/getAssetProofs.test.ts:16-16
Timestamp: 2025-04-22T09:44:46.042Z
Learning: For the PR transitioning from position/array-based RPC calls to object-based RPC calls in the digital-asset-standard-api, methods with only one parameter (like `getAssetProofs`) can remain using the direct parameter style rather than being converted to object-based.
Applied to files:
specification/metaplex-das-api.json
🔇 Additional comments (2)
specification/metaplex-das-api.json (2)
4-6
: Version bump needs matching changelog & server handshake updateGreat to see the spec moved to 1.1.1.
Double-check you also (a) publish release notes and (b) update the server’sHELLO
/capabilities endpoint so clients can negotiate the new version.
511-512
: Enum extension acknowledged – bump client code-gen
"MplBubblegumV2"
added tointerface
– ensure all generated SDKs regenerate their union/enum so they don’t reject this value at runtime.
No description provided.