Closed
Conversation
samvimes01
force-pushed
the
fix/multiline_requires
branch
from
e62d33c to
ef19a82
Compare
Member
Do not fix this before I will prepare tests to cover all cases we need |
samvimes01
force-pushed
the
fix/multiline_requires
branch
from
2c219f0 to
8e10602
Compare
samvimes01
commented
Feb 18, 2026
lib/process-imports.js
Outdated
| const namedParts = Array.from(named); | ||
|
|
||
| if (defaultNames.size === 0 && namedParts.length === 0) continue; | ||
|
|
samvimes01
force-pushed
the
fix/multiline_requires
branch
from
6c35d03 to
85aa2ce
Compare
samvimes01
force-pushed
the
fix/multiline_requires
branch
from
85aa2ce to
191f224
Compare
samvimes01
force-pushed
the
fix/multiline_requires
branch
from
b692c0d to
5ee3507
Compare
Member
|
Closed in favour of #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process whole file instead line by line to fix cases when multiple lines export or import encountered by builder
Add checks to import processing so only unique identifiers are set on top of a bundle
Warn if node internals are used -such esm lib would be invalid - but it's user responsibility to fix it
Add Generated by to header to mark that file shouldn't be edited manually instead rebuilt by this lib
tests and linter show no problems (
npm t)tests are added/updated for bug fixes and new features
code is properly formatted (
npm run fix)description of changes is added in CHANGELOG.md
update .d.ts typings