Add Claude Code configuration #224
Conversation
Add CLAUDE.md with project guidance for Claude Code including: - Build commands and Maven profiles documentation - Architecture overview with correct package structure - Command pattern inheritance hierarchy - Git workflow and worktree requirements - Testing and dependency information Also adds Claude settings.json for plugin configuration and updates .gitignore for Claude local files.
📝 WalkthroughWalkthroughAdds Claude Code integration artifacts: a repository guide ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2026-01-05T18:03:33.537ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.claude/CLAUDE.md:
- Line 86: Locate the bare URL
"https://github.com/metaschema-framework/oscal-cli" in the CLAUDE.md content and
replace the bare URL with markdown link syntax (e.g., use a [label](URL) form)
so the URL is wrapped as a proper Markdown link; ensure the link text is either
the same URL or a short descriptive label like "oscal-cli repository" and keep
the same URL target.
- Line 142: The markdown link to TESTING.md in CLAUDE.md is using a
same-directory target and therefore breaks; edit CLAUDE.md to update the
TESTING.md link so it uses a parent-directory relative target (pointing to the
repo root TESTING.md) instead of the current same-directory reference.
🧹 Nitpick comments (1)
.claude/CLAUDE.md (1)
79-82: Consider explicit Javadoc requirement in code style section.The code style section mentions Java 11 target and SpotBugs annotations but doesn't explicitly reference the Javadoc requirement. Based on learnings from the metaschema-java repository, CLAUDE.md is the canonical coding-guidelines document and should emphasize the Javadoc style guide requirement: 100% coverage on public/protected members with proper param, return, and throws tags.
Consider adding a line to the Code Style section referencing the Javadoc requirement:
📝 Proposed enhancement
## Code Style - Java 11 target - Uses SpotBugs annotations (`@NonNull`, `@Nullable`) for null safety +- All public/protected code requires 100% Javadoc coverage (see docs/javadoc-style-guide.md)
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.claude/CLAUDE.md.claude/settings.json.gitignore
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: david-waltermire
Repo: metaschema-framework/metaschema-java PR: 618
File: core/src/main/java/dev/metaschema/core/datatype/package-info.java:52-52
Timestamp: 2026-01-05T18:03:33.537Z
Learning: In metaschema-framework/metaschema-java, CLAUDE.md is the canonical coding-guidelines document and now specifies dev.metaschema.* as the Java package convention (updated in PR #618).
📚 Learning: 2026-01-05T18:03:33.537Z
Learnt from: david-waltermire
Repo: metaschema-framework/metaschema-java PR: 618
File: core/src/main/java/dev/metaschema/core/datatype/package-info.java:52-52
Timestamp: 2026-01-05T18:03:33.537Z
Learning: In metaschema-framework/metaschema-java, CLAUDE.md is the canonical coding-guidelines document and now specifies dev.metaschema.* as the Java package convention (updated in PR #618).
Applied to files:
.claude/CLAUDE.md.gitignore.claude/settings.json
📚 Learning: 2025-12-17T13:27:43.679Z
Learnt from: CR
Repo: metaschema-framework/metaschema-java PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-17T13:27:43.679Z
Learning: Applies to **/*.java : All code changes must follow the Javadoc style guide (docs/javadoc-style-guide.md). New code requires 100% Javadoc coverage on public/protected members. Modified code must add/update Javadoc on any members touched. All Javadoc must include param, return, throws tags in the correct order (BLOCKING)
Applied to files:
.claude/CLAUDE.md
🪛 markdownlint-cli2 (0.18.1)
.claude/CLAUDE.md
86-86: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Code
🔇 Additional comments (3)
.gitignore (1)
22-24: Proper exclusion of local Claude configuration files.The .gitignore entries correctly exclude local overrides while keeping versioned CLAUDE.md and settings.json files. The patterns are appropriately scoped.
.claude/CLAUDE.md (1)
1-160: Comprehensive and well-structured Claude Code guidance.The CLAUDE.md documentation provides clear, actionable guidance across build processes, project architecture, Git workflows, and testing. The mandatory worktree section (lines 91-135) is particularly valuable for preventing common development mistakes. Package structure descriptions correctly use the
dev.metaschema.*convention. Build commands are complete and helpful..claude/settings.json (1)
1-24: Verify plugin definitions in metaschema-framework/claude-plugins; superpowers marketplace confirmed.The repositories are accessible (HTTP 200), and the superpowers marketplace is confirmed to exist. However, the metaschema-framework/claude-plugins repository could not be independently verified to contain valid Claude plugin definitions. Confirm that the five metaschema plugins (metaschema, metaschema-tools, oscal, oscal-tools, dev-metaschema) are actually published in that marketplace before relying on this configuration.
- Wrap bare URL in angle brackets for proper markdown formatting - Fix TESTING.md link path to use relative parent directory
david-waltermire
merged commit 3c3404e
into
metaschema-framework:develop
1 participant
Summary
Test plan
Summary by CodeRabbit
Note: No changes to end-user functionality; these updates improve developer workflows.
✏️ Tip: You can customize this high-level summary in your review settings.