Add a heat flux wrapper #144
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GardevoirX
force-pushed
the
heat-flux-wrapper
branch
from
bc49697 to
04efdd2
Compare
Luthaf
reviewed
Jan 28, 2026
| super().__init__() | ||
|
|
||
| self._model = model | ||
| # TODO: throw error if the simulation cell is smaller than double the interaction range |
Member
There was a problem hiding this comment.
keep in mind that long-range models will have an infinite interaction range
Contributor
Author
There was a problem hiding this comment.
sure I will put it in the documentation that this method only supports local/semi-local models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104
This is still in a very early stage and subjected to change.
TODO:
Contributor (creator of pull-request) checklist
Reviewer checklist