Fix sceneDropId handling to prevent matching unintended assets#15
Open
Fix sceneDropId handling to prevent matching unintended assets#15
Conversation
All controllers now use the resolved sceneDropId from getDroppedAssetDataObject instead of directly using credentials.sceneDropId which could be empty. - getDroppedAssetDataObject now validates and returns the resolved sceneDropId - handleResetBoard uses resolved sceneDropId for queries and generateBoard calls - handleDropPiece uses resolved sceneDropId for asset queries - handlePlayerSelection uses resolved sceneDropId for asset queries This prevents queries with empty sceneDropId from matching all assets in a world. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All controllers now use the resolved sceneDropId from getDroppedAssetDataObject instead of directly using credentials.sceneDropId which could be empty.
This prevents queries with empty sceneDropId from matching all assets in a world.
Summary
Summarize the changes that have been made to the platform.
What kind of change does this PR introduce?
New feature, docs update, etc.
Current Behavior
Tell us what is happening currently.
New Behavior
What new feature or update to existing feature are you introducing?
Does this PR introduce a breaking change?
If so, please provide specifics.
Detailed Description and Additional Information
Provide a detailed description of the change or addition you are proposing.