updated flow router support to reflect changed API in v1.8.0#3
Open
richsilv wants to merge 2 commits intometeor-london:masterfrom
Open
updated flow router support to reflect changed API in v1.8.0#3richsilv wants to merge 2 commits intometeor-london:masterfrom
richsilv wants to merge 2 commits intometeor-london:masterfrom
Conversation
Member
|
No change to https://github.com/meteor-london/body-class/blob/master/package.js needed? If this is an api change then we should bump the minor version number rather than patch. |
Contributor
Author
|
Sorry, I don't really understand. We're updating the version number from 2.1.0 to 2.1.1 - are you saying we shouldn't be doing so? We have to bump it somehow in order to publish to Atmosphere. |
Member
|
https://github.com/meteor-london/body-class/blob/master/package.js lists api.use('meteorhacks:flow-router@1.4.0', 'client', { "weak": true })I figured that as this PR is about adopting the flow-router 1.8 api, I'd assume an update to that line. I don't know for a fact that it's required, so thought I'd ask. |
Contributor
Author
|
Ah, I see. Yes, that makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.