UseFind should work like other hooks#431
Merged
nachocodoner merged 1 commit intometeor:masterfrom Apr 3, 2025
Merged
Conversation
useFind default behavior is to have a void array as deps. This is confusing and leading to bugs hard to find
radekmie
approved these changes
Mar 28, 2025
Contributor
Author
|
Be carreful with this change @nachocodoner this should be flagged as a breaking change. Need to release a major version ??? |
Member
|
I didn't realize it. Ok, it may affect unexpectedly for some. I will update the changelog. Anyway, the new realese is a beta, we'll consider for the official. Good catch, thank you. |
Member
|
cherrying-pick this commit to #448 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useFind default behavior is to have a void array as deps. This is confusing and leading to bugs hard to find.
useFind should work like useMemo, useEffect and usedTracker, having an undefined deps by default