Accept contributions around suspense and performance on useFind and useSubscribe hooks#435
Merged
nachocodoner merged 6 commits intomasterfrom Apr 10, 2025
Merged
Conversation
In strict mode (development only), useEffect may run 1-2 times. Throwing a promise outside can cause premature cleanup of subscriptions and cachedSubscription before unmount. To avoid this, check the timeout to ensure cleanup only occurs after unmount.
… server side and improved performance 1. On the server, useEffect doesn't run, so cached find data isn't cleared. Even after database updates, stale data is returned on subsequent requests. 2. useFindSuspense can't run on the client (non-reactive data makes it pointless), so the useEffect part was removed. 3. lodash.remove is no longer in use and can be removed. 4. According to 7d45b72, the package-lock.json file can be deleted. This PR depends on #429
…ache invalidation
nachocodoner
changed the title
Member
Author
|
We will release these along with other latest contributions in the next react packages release beta version. |
italojs
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues: #430 and #429
This PR is to verify, solve conflicts and consolidate contributions done to fix and improve performance on react hooks.