refactor: replace lodash with fast-equals #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nachocodoner
approved these changes
Oct 14, 2025
Member
There was a problem hiding this comment.
I think strictDeepEqual (strict equality (===) for primitive values, no type coercion) is the closest equivalent of Lodash's isEqual.
I accept this change, I will publish it soon. This will also make the runtime more performant in theory 🚀
Thanks for the contribution
Contributor
|
Published this under [email protected] please give a test and let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I would like to propose to replace
lodash.isequalwith fast-equalsstrictDeepEqual.I was not entirely sure if deepEqual or strictDeepEqual would be the correct replacement.
I want to replace it because vite has issues with the import of
lodash.isequaland the package is already deprecated.