Conversation
| cd ../../ | ||
| rm -rf build | ||
|
|
||
| echo "GAP benchmark suite installed into ${BENCHMARKS_DIR}" |
There was a problem hiding this comment.
Where are you providing the compile commands for the 3 gap benchmarks ?
There was a problem hiding this comment.
The make command on line 16 builds all benchmarks. By default it compiles with -O3 flag, I think in the script you shared with me you compiled with -O2. Do you want to switch to -O2 ?
| scale-factor: 1 | ||
| runtime: 1 | ||
|
|
||
| - benchmark: gapbs_bc |
There was a problem hiding this comment.
This benchmark uses OpenMP. Do you think we should let it default OMP threads or we should specify that as one of the benchmark inputs?
There was a problem hiding this comment.
Today, the user can set the OMP_NUM_THREADS variable in their shell, and the benchmark should pick it up.
Example:
$ OMP_NUM_THREADS=1 python3.6 ./benchpress_cli.py -b benchmarks.yml -j jobs/jobs.yml run gapbs_bfs
Will run 1 job(s)
Running "gapbs_bfs": GAP bfs benchmark
{
"average_time": 0.09154,
"build_time": 8.41545,
"generate_time": 1.42859,
"trial_time": 0.09154
}
But to be more explicit, we could potentially add support for environment variables, perhaps something like:
benchmark: gapbs_bc
name: gapbs_bc
description: GAP bc benchmark
env:
OMP_NUM_THREADS: 4
args:
- -u 21
- -n 1
Adds GAP benchmarking suite to Benchpress
Actual output of running benchmark through Benchpress:
@adhanotia Please review, but don't merge.