Skip to content

Inject data only when renders via Meteor #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Inject data only when renders via Meteor #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ http.OutgoingMessage.prototype.write = function(chunk, encoding) {
var condition =
this._injectPayload && !this._injected &&
encoding === undefined &&
/<!DOCTYPE html>/.test(chunk);
/<!DOCTYPE html>/.test(chunk) &&
/Content-Type: text\/html/.test(this._header);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? Seems bit confusing to me?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, a bit odd. But it works with SSR with _escaped_fragment_ this way.


if(condition) {
// if cors headers included if may cause some security holes
Expand Down Expand Up @@ -54,4 +55,4 @@ http.OutgoingMessage.prototype.write = function(chunk, encoding) {
}

originalWrite.call(this, chunk, encoding);
};
};