test(book): refactor tests to use ArgumentCaptor and ParameterizedTest #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs a technical refactor of BookServiceTest.java to improve test reliability, reduce code redundancy, and enforce stricter assertion logic.
The primary goal is to ensure tests verify the data mapping logic (input passed to the repository) rather than just the mock's return value, mitigating the risk of false positives.
Key Changes:
Why this matters:
Previously, tests could pass even if the Service layer truncated or altered data, because we were asserting against the Mock's configured response. Using ArgumentCaptor validates the actual transformation logic within the Service.
Checklist:
[x] - Tests pass
[x] - CI/CD passes