attempt to handle rose rsync can_pull errors better

[wxtim]

Fixes problem not recorded in an issue:

Issue

Rose has a routine to work out which file_loc_handler should be used based on the content of the source= field. However, the function called by the rsync loc handler will attempt to run

# loc handler = foo:bar
ssh -n foo test -e bar

As part of the method used to decide if the source is an Rsync handler. This fails in a difficult to debug way, as it's unclear whether the rsync check routine failed because the host was unreachable, or the file didn't exist, or the source was not meant to be a location reached by rsync, or was just garbage.

This PR

• Ensures that Rsync is always the last handler tried.
• Allows the rsync handler to raise more informative errors.
• Give the user more useful detail if the loc handler cannot be identified because this ssh check fails.

[oliver-sanders]

Did you manage to work out why the command stderr was not logged?

[wxtim]

Did you manage to work out why the command stderr was not logged?

Because no one made Rose log it.

When I was testing it in front of you and there was no output, that was because test -e nonexistant doesn't return any stdout/err.

On consideration, I should probably have a specific error message for this outcome!

[oliver-sanders]

Because no one made Rose log it.

I would expect there to be some standard way of doing this (else we would have to do this for every single command individually).

From a quick code skim, it looks like this is the centralised logic:

rose/metomi/rose/popen.py

Lines 44 to 61 in 26a6066

	class RosePopenError(Exception):
	"""An error raised when a shell command call fails."""
	def __init__(self, command, ret_code, stdout, stderr, stdin=None):
	self.command = command
	self.ret_code = ret_code
	self.stdout = stdout
	self.stderr = stderr
	self.stdin = stdin
	Exception.__init__(self, command, ret_code, stdout, stderr)
	def __str__(self):
	cmd_str = str(RosePopenEvent(self.command, self.stdin))
	tail = ""
	if self.stderr:
	tail = ", stderr=\n%s" % self.stderr
	return "%s # return-code=%d%s" % (cmd_str, self.ret_code, tail)

So, I think the issue here, is that this command swallows the RosePopenError rather than allowing it to bubble up and be reported as intended?

[wxtim]

@oliver-sanders Poke

[oliver-sanders]

You may want to consider changing to a bugfix branch.

Plz squash merge.