Add remote write for metric-explorer-prometheus #542
Add remote write for metric-explorer-prometheus #542taikulawo wants to merge 11 commits intometrics-rs:mainfrom
Conversation
|
close #540 |
taikulawo
changed the title
| prometheus_parse::Value::Counter(v) => v, | ||
| prometheus_parse::Value::Gauge(v) => v, | ||
| prometheus_parse::Value::Histogram(_) => { | ||
| Err("histogram not supported yet".to_string())? |
There was a problem hiding this comment.
@tobz I'm not sure how to process histogram and summary
taikulawo
changed the title
tobz
left a comment
tobz
left a comment
There was a problem hiding this comment.
Well that was fast. :)
The comment about not knowing how to handle histograms/summaries highlights what I see as the biggest thing that needs to change with this PR: we shouldn't be generating the exposition format only then to parse it back into an intermediate representation only to then encode it a second time in the Remote Write format.
We should simply be writing a new method on Inner that generates the encoded/compressed payload similar to how Inner::render does it, by evaluating the individual counters, gauges, and histograms.
|
I don't know too much inner detail about metrics. No idea how to build from inner type. But other codes should correct. |
2 participants
https://prometheus.io/docs/specs/remote_write_spec/