Prometheus push gateway: opt-out of the default tls provider #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhramov
force-pushed
the
feature/prometheus-exporter-no-tls
branch
from
35e3716 to
3559b43
Compare
tobz
added
C-exporter
|
@akhramov Seems like this just needs formatting and it should be good to go. |
akhramov
force-pushed
the
feature/prometheus-exporter-no-tls
branch
from
3559b43 to
3fd8bb0
Compare
|
@tobz thanks, fixed! |
This is a follow up to metrics-rs#516, metrics-rs#516 (comment). This change makes it possible for downstream projects to opt-out of the default rustls provider (aws-lc-rs). Hopefully closes metrics-rs#515
akhramov
force-pushed
the
feature/prometheus-exporter-no-tls
branch
from
374e409 to
8c729e7
Compare
|
@tobz, I am sorry for pinging you, but is there anything we need to do with this PR before we move forward? |
|
@akhramov No worries, I've just been super busy with work and life lately. :) I'll try and take a final pass over this either today or tomorrow. If I remember correctly, I think everything mostly looked good when I first reviewed it, so I just need to do a refresher here before signing off on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #516, #516 (comment).
This change makes it possible for downstream projects to opt-out of the default rustls provider (aws-lc-rs).
Hopefully closes #515