comment for #769

mevdschee · mevdschee · commit 165218f465d7 · 2021-03-16T11:25:02.000+01:00
diff --git a/api.include.php b/api.include.php
@@ -6364,7 +6364,7 @@ public function getTableColumns(string $tableName, string $type): array
             }
             if ($this->driver == 'sqlite') {
                 foreach ($results as &$result) {
-                    // sqlite does not properly reflect display width of types
+                    // sqlite does not reflect types on view columns
                     preg_match('|([a-z]+)(\(([0-9]+)(,([0-9]+))?\))?|', $result['DATA_TYPE'], $matches);
                     if (isset($matches[1])) {
                         $result['DATA_TYPE'] = $matches[1];
diff --git a/api.php b/api.php
@@ -6364,7 +6364,7 @@ public function getTableColumns(string $tableName, string $type): array
             }
             if ($this->driver == 'sqlite') {
                 foreach ($results as &$result) {
-                    // sqlite does not properly reflect display width of types
+                    // sqlite does not reflect types on view columns
                     preg_match('|([a-z]+)(\(([0-9]+)(,([0-9]+))?\))?|', $result['DATA_TYPE'], $matches);
                     if (isset($matches[1])) {
                         $result['DATA_TYPE'] = $matches[1];

Original file line number	Diff line number	Diff line change
`@@ -6364,7 +6364,7 @@ public function getTableColumns(string $tableName, string $type): array`
`6364`	`6364`	`}`
`6365`	`6365`	`if ($this->driver == 'sqlite') {`
`6366`	`6366`	`foreach ($results as &$result) {`
`6367`		`- // sqlite does not properly reflect display width of types`
	`6367`	`+ // sqlite does not reflect types on view columns`
`6368`	`6368`	`preg_match('\|([a-z]+)(\(([0-9]+)(,([0-9]+))?\))?\|', $result['DATA_TYPE'], $matches);`
`6369`	`6369`	`if (isset($matches[1])) {`
`6370`	`6370`	`$result['DATA_TYPE'] = $matches[1];`