Skip to content

Commit 4cd4a5c

Browse files
committed
use PSR-7 for Firewall middleware
1 parent 7bee184 commit 4cd4a5c

File tree

4 files changed

+24
-6
lines changed

4 files changed

+24
-6
lines changed

api.include.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7932,14 +7932,20 @@ private function isIpAllowed(string $ipAddress, string $allowedIpAddresses): boo
79327932
return false;
79337933
}
79347934

7935+
private function getIpAddress(ServerRequestInterface $request): string
7936+
{
7937+
$serverParams = $request->getServerParams();
7938+
return $serverParams['REMOTE_ADDR'] ?? '127.0.0.1';
7939+
}
7940+
79357941
public function process(ServerRequestInterface $request, RequestHandlerInterface $next): ResponseInterface
79367942
{
79377943
$reverseProxy = $this->getProperty('reverseProxy', '');
79387944
$serverParams = $request->getServerParams();
79397945
if ($reverseProxy) {
79407946
$ipAddress = array_pop($request->getHeader('X-Forwarded-For'));
79417947
} else {
7942-
$ipAddress = $serverParams['REMOTE_ADDR'] ?? '127.0.0.1';
7948+
$ipAddress = $this->getIpAddress($request);
79437949
}
79447950
$allowedIpAddresses = $this->getProperty('allowedIpAddresses', '');
79457951
if (!$this->isIpAllowed($ipAddress, $allowedIpAddresses)) {
@@ -7958,8 +7964,8 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
79587964
use Psr\Http\Message\ResponseInterface;
79597965
use Psr\Http\Message\ServerRequestInterface;
79607966
use Psr\Http\Server\RequestHandlerInterface;
7961-
use Tqdev\PhpCrudApi\Column\Reflection\ReflectedTable;
79627967
use Tqdev\PhpCrudApi\Column\ReflectionService;
7968+
use Tqdev\PhpCrudApi\Column\Reflection\ReflectedTable;
79637969
use Tqdev\PhpCrudApi\Controller\Responder;
79647970
use Tqdev\PhpCrudApi\Middleware\Base\Middleware;
79657971
use Tqdev\PhpCrudApi\Middleware\Router\Router;

api.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7932,14 +7932,20 @@ private function isIpAllowed(string $ipAddress, string $allowedIpAddresses): boo
79327932
return false;
79337933
}
79347934

7935+
private function getIpAddress(ServerRequestInterface $request): string
7936+
{
7937+
$serverParams = $request->getServerParams();
7938+
return $serverParams['REMOTE_ADDR'] ?? '127.0.0.1';
7939+
}
7940+
79357941
public function process(ServerRequestInterface $request, RequestHandlerInterface $next): ResponseInterface
79367942
{
79377943
$reverseProxy = $this->getProperty('reverseProxy', '');
79387944
$serverParams = $request->getServerParams();
79397945
if ($reverseProxy) {
79407946
$ipAddress = array_pop($request->getHeader('X-Forwarded-For'));
79417947
} else {
7942-
$ipAddress = $serverParams['REMOTE_ADDR'] ?? '127.0.0.1';
7948+
$ipAddress = $this->getIpAddress($request);
79437949
}
79447950
$allowedIpAddresses = $this->getProperty('allowedIpAddresses', '');
79457951
if (!$this->isIpAllowed($ipAddress, $allowedIpAddresses)) {
@@ -7958,8 +7964,8 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
79587964
use Psr\Http\Message\ResponseInterface;
79597965
use Psr\Http\Message\ServerRequestInterface;
79607966
use Psr\Http\Server\RequestHandlerInterface;
7961-
use Tqdev\PhpCrudApi\Column\Reflection\ReflectedTable;
79627967
use Tqdev\PhpCrudApi\Column\ReflectionService;
7968+
use Tqdev\PhpCrudApi\Column\Reflection\ReflectedTable;
79637969
use Tqdev\PhpCrudApi\Controller\Responder;
79647970
use Tqdev\PhpCrudApi\Middleware\Base\Middleware;
79657971
use Tqdev\PhpCrudApi\Middleware\Router\Router;

src/Tqdev/PhpCrudApi/Middleware/FirewallMiddleware.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,20 @@ private function isIpAllowed(string $ipAddress, string $allowedIpAddresses): boo
3636
return false;
3737
}
3838

39+
private function getIpAddress(ServerRequestInterface $request): string
40+
{
41+
$serverParams = $request->getServerParams();
42+
return $serverParams['REMOTE_ADDR'] ?? '127.0.0.1';
43+
}
44+
3945
public function process(ServerRequestInterface $request, RequestHandlerInterface $next): ResponseInterface
4046
{
4147
$reverseProxy = $this->getProperty('reverseProxy', '');
4248
$serverParams = $request->getServerParams();
4349
if ($reverseProxy) {
4450
$ipAddress = array_pop($request->getHeader('X-Forwarded-For'));
4551
} else {
46-
$ipAddress = $serverParams['REMOTE_ADDR'] ?? '127.0.0.1';
52+
$ipAddress = $this->getIpAddress($request);
4753
}
4854
$allowedIpAddresses = $this->getProperty('allowedIpAddresses', '');
4955
if (!$this->isIpAllowed($ipAddress, $allowedIpAddresses)) {

src/Tqdev/PhpCrudApi/Middleware/IpAddressMiddleware.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
use Psr\Http\Message\ResponseInterface;
66
use Psr\Http\Message\ServerRequestInterface;
77
use Psr\Http\Server\RequestHandlerInterface;
8-
use Tqdev\PhpCrudApi\Column\Reflection\ReflectedTable;
98
use Tqdev\PhpCrudApi\Column\ReflectionService;
9+
use Tqdev\PhpCrudApi\Column\Reflection\ReflectedTable;
1010
use Tqdev\PhpCrudApi\Controller\Responder;
1111
use Tqdev\PhpCrudApi\Middleware\Base\Middleware;
1212
use Tqdev\PhpCrudApi\Middleware\Router\Router;

0 commit comments

Comments
 (0)