Skip to content

Docker file for CSSIFY #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aeyshubh wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Docker file for CSSIFY #23

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
259faa3
Co-authored-by: Sanskar Jethi <[email protected]>
aeyshubh Feb 25, 2021
f4b67d7
Updated and final docker file
aeyshubh Feb 26, 2021
bf9838d
Delete package-lock.json
aeyshubh Feb 27, 2021
d660d82
Deleted Package lock .json
aeyshubh Feb 27, 2021
4723a01
Updated the version of node
aeyshubh Feb 27, 2021
5eccd80
Removed Socket.io
aeyshubh Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
node_modules
3 changes: 2 additions & 1 deletion backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"author": "Siddharth S",
"license": "MIT",
"dependencies": {
"@node-minify/core": "^5.3.0",
"@node-minify/core": "^6.2.0",
"@node-minify/cssnano": "^5.3.0",
"compression": "^1.7.4",
"concurrently": "^5.2.0",
Expand All @@ -25,6 +25,7 @@
"helmet": "^3.22.0",
"node-sass": "^4.14.1",
"node-sass-json-importer": "^4.3.0",
"socket.io": "^3.1.2",
Copy link
Member

@sansyrox sansyrox Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you add this module?

Copy link
Author

@aeyshubh aeyshubh Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were automatically been made while making the docker file

Copy link
Member

@sansyrox sansyrox Mar 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPatel33, please remove the socket io dependency as it is not required. And sorry for the slow reviews, have been a little occupied lately.

Copy link
Author

@aeyshubh aeyshubh Mar 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the socket.io,will it gonna count in Mwoc as the PR was made in the mentioned date and the changes took some time .

"uuid": "^8.1.0"
},
"devDependencies": {
Expand Down
Loading