Updating FMS-moving out of figure file and plotting functions#17
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the FMS-related code by moving FMS calculation from the figure file into the factorization file and centralizing the plotting functions into a common plotting module. Key changes include:
- Activating the plot_fms_percent_drop function in the figure module with an added rank parameter.
- Adjusting the range of component indices passed to the plotting function.
- Extracting and re-implementing FMS calculation and plotting functions within the factorization and commonFuncs modules.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pf2rnaseq/figures/figureHeiserFMS.py | Removed redundant functions and updated plotting call parameters. |
| pf2rnaseq/figures/commonFuncs/plotGeneral.py | Introduced centralized plotting functions for FMS. |
| pf2rnaseq/factorization.py | Added FMS calculation and new plotting utility functions. |
Comments suppressed due to low confidence (2)
pf2rnaseq/figures/figureHeiserFMS.py:24
- The change in the rank range from [30, 51) to [1, 31) represents a significant alteration in behavior. Please verify that this updated range aligns with the intended component indices for the FMS figures.
ranks = list(range(1, 31))
pf2rnaseq/factorization.py:43
- The removal of the 'regParam' parameter from the pf2 function changes its interface. Confirm that all dependent code has been updated accordingly and that this change is in line with the intended design.
tolerance=1e-9,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved FMS calculation to factorization file and plotting to plotGeneral file.