Merged
Conversation
…ml. Other minor fix. Build seems okay in my local env.
…l will continue to work...for now
(WIP) further cleaning
sshiraiwa
approved these changes
Jun 5, 2025
Member
sshiraiwa
left a comment
sshiraiwa
left a comment
There was a problem hiding this comment.
Approved. Once test passes. Will be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an in-progress attempt at cleaning up our build script. I saw that we introduced a
.tomlfile in this branch so I shifted over some responsibilities there. Eventually I'm hoping we can usescikit-build(or something else).I did bump the
numpyversion to>=2.0.0(is this okay?). Support for< 2.0.0is ending in November so if we can upgrade it would be nice (the Colab notebooks have also updated to2.0.0so we have to hack our away around that).