-
Notifications
You must be signed in to change notification settings - Fork 67
Pickup dpg-dev and particleset/particlevector.hpp wrapping. #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sshiraiwa
wants to merge
34
commits into
master
Choose a base branch
from
dpg-merge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
446f080
Merge pull request #269 from mfem/mfem_48_dev
sshiraiwa ccac1f7
added wrappers for miniapps/dpg/utils
sshiraiwa 0383446
Merge branch 'mfem_48_dev' into dpg_dev
sshiraiwa 3b56b38
minor edit to setup.py
sshiraiwa 6a13251
Merge branch 'mfem_48_dev' into dpg_dev
sshiraiwa 2201fb9
pmaxwell.py
sshiraiwa 4d3b446
pmaxwell.py
sshiraiwa 0e11b17
(WIP) work in progress
sshiraiwa bb3f56e
made ser/par.dpg module to load all dpg related routines
sshiraiwa 26657dc
(WIP)...pmaxwell.py
sshiraiwa e234fca
(WIP) pmaxwell
sshiraiwa e1914ba
(WIP...)
sshiraiwa ceeaca7
merged
sshiraiwa 1782435
merged
sshiraiwa 96a3d26
(WIP) pmaxwell.py seems okay
sshiraiwa 8ae8d8e
merged new build-install system
sshiraiwa b05be34
Merge remote-tracking branch 'origin/mfem_48_dev' into dpg_dev
sshiraiwa 3da4f4f
merged
sshiraiwa 68f5506
removed rectangular matrix coefficient warnings
sshiraiwa f8a77e5
Merge branch 'dpg_dev' of github.com:mfem/PyMFEM into dpg_dev
sshiraiwa 993774c
preparig for merge
sshiraiwa cf44e73
Merge branch 'dpg_dev' of github.com:mfem/PyMFEM into dpg_dev
sshiraiwa 3cca3b7
improved DPGweakform constructor. Instead of passing mfem::Array, we …
sshiraiwa 9b68fe8
merged perlmutter_fix
sshiraiwa 8e69e62
(WIP)
sshiraiwa d75793c
added partcileset/particlevector wrapping
sshiraiwa c7ebcef
merged dpg
sshiraiwa 2f29cfd
addressed change in hypre.hpp to fix const correctness (https://githu…
sshiraiwa 69b975e
Merge branch 'fix_hypre_typemap' into dgp_merge
sshiraiwa 4e9df3a
picked-up dpg-dev branch, added link to the orignal object when Vecto…
sshiraiwa 81e3435
merged particleset/particlevector branch
sshiraiwa 96c2d21
update change log
sshiraiwa 7ba9465
fixed DenseMatrix::GetDataArray()
sshiraiwa 49d6112
minor fix...response to copilot...
sshiraiwa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,6 +2,14 @@ | |||||
| 2025 12 | ||||||
| * PyMFEM4.9 | ||||||
| - ordering.i is added and made correponding adjustment in *.i files. | ||||||
|
||||||
| - ordering.i is added and made correponding adjustment in *.i files. | |
| - ordering.i is added and made corresponding adjustment in *.i files. |
Copilot
AI
Jan 1, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the changelog, "destructore" is misspelled. It should be "destructor".
Suggested change
| destructore is not pre-maturely called when return value is not stored to | |
| destructor is not pre-maturely called when return value is not stored to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| %module(package="mfem._par") blockstaticcond | ||
| %{ | ||
| #include "mfem.hpp" | ||
| #include "numpy/arrayobject.h" | ||
| #include "miniapps/dpg/util/blockstaticcond.hpp" | ||
| #include "../common/pyoperator.hpp" | ||
| #include "../common/pysolvers.hpp" | ||
| #include "../common/pycoefficient.hpp" | ||
| #include "../common/pyintrules.hpp" | ||
| #include "../common/pybilininteg.hpp" | ||
| #include "../common/pynonlininteg.hpp" | ||
| #include "../common/io_stream.hpp" | ||
| %} | ||
|
|
||
| %include "../common/existing_mfem_headers.i" | ||
| #ifdef FILE_EXISTS_MINIAPPS_DPG_UTIL_BLOCKSTATICCOND | ||
|
|
||
| %init %{ | ||
| import_array(); | ||
| %} | ||
|
|
||
| %inline %{ | ||
| #include "miniapps/dpg/util/blockstaticcond.cpp" | ||
| %} | ||
|
|
||
|
|
||
| %include "exception.i" | ||
| %import "element.i" | ||
| %import "../common/exception.i" | ||
|
|
||
| %import "array.i" | ||
| %import "vector.i" | ||
| %import "densemat.i" | ||
| %import "operators.i" | ||
| %import "blockmatrix.i" | ||
| %import "blockoperator.i" | ||
| %import "fespace.i" | ||
| %import "../common/exception.i" | ||
| %import "../common/io_stream_typemap.i" | ||
|
|
||
| OSTREAM_TYPEMAP(std::ostream&) | ||
|
|
||
| %ignore mfem::BlockStaticCondensation::ConvertListToReducedTrueDofs; | ||
| %include "miniapps/dpg/util/blockstaticcond.hpp" | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| %module(package="mfem._par") complex_densemat | ||
| %{ | ||
| #include "mfem.hpp" | ||
| #include "numpy/arrayobject.h" | ||
| #include "../common/pyoperator.hpp" | ||
| #include "../common/pysolvers.hpp" | ||
| #include "../common/pycoefficient.hpp" | ||
| #include "../common/pyintrules.hpp" | ||
| #include "../common/pybilininteg.hpp" | ||
| #include "../common/pynonlininteg.hpp" | ||
| #include "../common/io_stream.hpp" | ||
| %} | ||
|
|
||
| %init %{ | ||
| import_array(); | ||
| %} | ||
|
|
||
| %include "exception.i" | ||
| %import "element.i" | ||
| %import "../common/exception.i" | ||
|
|
||
| %import "array.i" | ||
| %import "vector.i" | ||
| %import "densemat.i" | ||
| %import "complex_operator.i" | ||
| %import "../common/exception.i" | ||
| %import "../common/io_stream_typemap.i" | ||
|
|
||
| %ignore mfem::ComplexLUFactors::Mult(int m, int n, std::complex<real_t> *X) const; | ||
| %include "linalg/complex_densemat.hpp" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| %module(package="mfem._par") complexstaticcond | ||
| %{ | ||
| #include "mfem.hpp" | ||
| #include "numpy/arrayobject.h" | ||
| #include "miniapps/dpg/util/complexstaticcond.hpp" | ||
| #include "../common/pyoperator.hpp" | ||
| #include "../common/pysolvers.hpp" | ||
| #include "../common/pycoefficient.hpp" | ||
| #include "../common/pyintrules.hpp" | ||
| #include "../common/pybilininteg.hpp" | ||
| #include "../common/pynonlininteg.hpp" | ||
| #include "../common/io_stream.hpp" | ||
| %} | ||
|
|
||
| %include "../common/existing_mfem_headers.i" | ||
| #ifdef FILE_EXISTS_MINIAPPS_DPG_UTIL_COMPLEXSTATICCOND | ||
|
|
||
| %init %{ | ||
| import_array(); | ||
| %} | ||
|
|
||
| %inline %{ | ||
| #include "miniapps/dpg/util/complexstaticcond.cpp" | ||
| %} | ||
|
|
||
|
|
||
| %include "exception.i" | ||
| %import "element.i" | ||
| %import "../common/exception.i" | ||
|
|
||
| %import "array.i" | ||
| %import "vector.i" | ||
| %import "gridfunc.i" | ||
| %import "mesh.i" | ||
| %import "solvers.i" | ||
| %import "operators.i" | ||
| %import "blockmatrix.i" | ||
| %import "blockoperator.i" | ||
| %import "complex_densemat.i" | ||
| %import "../common/exception.i" | ||
| %import "../common/io_stream_typemap.i" | ||
|
|
||
| OSTREAM_TYPEMAP(std::ostream&) | ||
|
|
||
| %ignore mfem::ComplexBlockStaticCondensation::ConvertListToReducedTrueDofs; | ||
| %include "miniapps/dpg/util/complexstaticcond.hpp" | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| %module(package="mfem._par") complexweakform | ||
| %{ | ||
| #include "mfem.hpp" | ||
| #include "numpy/arrayobject.h" | ||
| #include "miniapps/dpg/util/complexweakform.hpp" | ||
| #include "../common/pyoperator.hpp" | ||
| #include "../common/pysolvers.hpp" | ||
| #include "../common/pycoefficient.hpp" | ||
| #include "../common/pyintrules.hpp" | ||
| #include "../common/pylininteg.hpp" | ||
| #include "../common/pybilininteg.hpp" | ||
| #include "../common/pynonlininteg.hpp" | ||
| #include "../common/io_stream.hpp" | ||
| %} | ||
|
|
||
| %include "../common/existing_mfem_headers.i" | ||
| #ifdef FILE_EXISTS_MINIAPPS_DPG_UTIL_COMPLEXWEAKFORM | ||
|
|
||
| %init %{ | ||
| import_array(); | ||
| %} | ||
|
|
||
| %inline %{ | ||
| #include "miniapps/dpg/util/complexweakform.cpp" | ||
| %} | ||
|
|
||
|
|
||
| %include "exception.i" | ||
| %import "element.i" | ||
| %import "../common/exception.i" | ||
|
|
||
| %import "coefficient.i" | ||
| %import "gridfunc.i" | ||
| %import "mesh.i" | ||
| %import "solvers.i" | ||
| %import "operators.i" | ||
| %import "blockmatrix.i" | ||
| %import "../common/exception.i" | ||
| %import "../common/io_stream_typemap.i" | ||
|
|
||
| OSTREAM_TYPEMAP(std::ostream&) | ||
|
|
||
| %import "../common/object_array_typemap.i" | ||
| LIST_TO_MFEMOBJ_ARRAY_IN(const mfem::Array<mfem::FiniteElementSpace*>&, | ||
| mfem::FiniteElementSpace*) | ||
| LIST_TO_MFEMOBJ_ARRAY_IN(const mfem::Array<mfem::FiniteElementCollection*>&, | ||
| mfem::FiniteElementCollection*) | ||
|
|
||
|
|
||
| %pythonprepend mfem::ComplexDPGWeakForm::ComplexDPGWeakForm %{ | ||
| if len(args) > 0: | ||
| fes_, fecol_ = args | ||
| self._fes = fes_ | ||
| self._fecol = fecol_ | ||
| %} | ||
|
|
||
| %pythonprepend mfem::ComplexDPGWeakForm::SetSpaces %{ | ||
| self._fes = fes_ | ||
| self._fecol = fecol_ | ||
| %} | ||
|
|
||
|
|
||
| %include "miniapps/dpg/util/complexweakform.hpp" | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value for mfem_miniapps is changed from False to True. This is a significant behavior change that could affect existing workflows. Consider whether this should default to False for backward compatibility, or ensure this change is well-documented in the PR description.