Adjusting post_save User model import#7
Conversation
Moved post_save signal to __init__. Added noqa flake8 to ignore unused imports.
|
Thanks for the pull request. I see two parts to it. The first the NOQA markings for flake8 - I think I've addressed that since this PR was made on develop by adding an The second - django 1.7 best practices with the signal registration - it looks like the best practice is explained here: https://docs.djangoproject.com/en/dev/topics/signals/#django.dispatch.receiver Looking at that, I'm thinking something like in simple_email_confirmation/signals.py Then, per https://docs.djangoproject.com/en/dev/ref/applications/#configuring-applications we should define a Final, I think the signal definitions currently in simple_email_confirmation/signals.py should probably be moved to models.py to ensure they're always imported, even in django < 1.7. Thoughts? |
Moved post_save signal to init.
Added noqa flake8 to ignore unused imports.