Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ description = "Experiments with Java"

allprojects {
group = "io.github.mfvanek"
version = "0.3.2"
version = "0.3.3"

repositories {
mavenLocal()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,28 +119,28 @@ tasks {
limit {
counter = "METHOD"
value = "MISSEDCOUNT"
maximum = "3.0".toBigDecimal()
maximum = "2.0".toBigDecimal()
}
}
rule {
limit {
counter = "LINE"
value = "MISSEDCOUNT"
maximum = "10.0".toBigDecimal()
maximum = "7.0".toBigDecimal()
}
}
rule {
limit {
counter = "INSTRUCTION"
value = "COVEREDRATIO"
minimum = "0.90".toBigDecimal()
minimum = "0.93".toBigDecimal()
}
}
rule {
limit {
counter = "BRANCH"
value = "COVEREDRATIO"
minimum = "0.65".toBigDecimal()
minimum = "0.66".toBigDecimal()
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ include("db-migrations")
dependencyResolutionManagement {
versionCatalogs {
create("libs") {
val springBoot3Version = version("spring-boot-v3", "3.3.9")
val springBoot3Version = version("spring-boot-v3", "3.4.4")
plugin("spring-boot-v3", "org.springframework.boot")
.versionRef(springBoot3Version)
library("spring-boot-v3-dependencies", "org.springframework.boot", "spring-boot-dependencies")
Expand Down
1 change: 1 addition & 0 deletions spring-boot-2-demo-app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ dependencies {
implementation("org.springframework.boot:spring-boot-starter-web")
implementation("org.springframework.boot:spring-boot-starter-webflux")
implementation("org.springframework.boot:spring-boot-starter-actuator")
implementation("org.springframework.boot:spring-boot-starter-security")
implementation("io.micrometer:micrometer-registry-prometheus")
implementation("org.springdoc:springdoc-openapi-ui")

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/*
* Copyright (c) 2020-2025. Ivan Vakhrushev and others.
* https://github.com/mfvanek/spring-boot-open-telemetry-demo
*
* Licensed under the Apache License 2.0
*/

package io.github.mfvanek.spring.boot2.test.config;

import lombok.SneakyThrows;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
import org.springframework.security.web.SecurityFilterChain;

@Configuration(proxyBeanMethods = false)
public class SecurityConfig {

@Bean
@SneakyThrows

Check warning on line 20 in spring-boot-2-demo-app/src/main/java/io/github/mfvanek/spring/boot2/test/config/SecurityConfig.java

View check run for this annotation

Codecov / codecov/patch

spring-boot-2-demo-app/src/main/java/io/github/mfvanek/spring/boot2/test/config/SecurityConfig.java#L20

Added line #L20 was not covered by tests
public SecurityFilterChain securityFilterChain(HttpSecurity http) {
http.authorizeHttpRequests(authorize ->
authorize.anyRequest().permitAll());
return http.build();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/*
* Copyright (c) 2020-2025. Ivan Vakhrushev and others.
* https://github.com/mfvanek/spring-boot-open-telemetry-demo
*
* Licensed under the Apache License 2.0
*/

package io.github.mfvanek.spring.boot2.test.controllers;

import io.github.mfvanek.spring.boot2.test.support.TestBase;
import org.junit.jupiter.api.Test;

import static io.github.mfvanek.spring.boot2.test.filters.TraceIdInResponseServletFilter.TRACE_ID_HEADER_NAME;
import static org.assertj.core.api.Assertions.assertThat;

class RedirectControllerTest extends TestBase {

@Test
void redirectShouldWork() {
final Object result = webTestClient.get()
.uri("/redirect")
.exchange()
.expectStatus().isEqualTo(303)
.expectHeader().exists(TRACE_ID_HEADER_NAME)
.expectHeader().location("https://www.google.com")
.expectBody(Object.class)
.returnResult()
.getResponseBody();
assertThat(result)
.isNull();
}
}
7 changes: 4 additions & 3 deletions spring-boot-3-demo-app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@ plugins {

dependencies {
implementation(platform(project(":common-internal-bom")))
implementation(platform("org.springdoc:springdoc-openapi:2.6.0"))
implementation(platform("org.springdoc:springdoc-openapi:2.8.6"))
implementation(platform(libs.spring.boot.v3.dependencies))
implementation(platform("org.springframework.cloud:spring-cloud-dependencies:2023.0.5"))
implementation(platform("org.springframework.cloud:spring-cloud-dependencies:2024.0.1"))

implementation("org.springframework.boot:spring-boot-starter-web")
implementation("org.springframework.boot:spring-boot-starter-webflux")
implementation("org.springframework.boot:spring-boot-starter-actuator")
implementation("org.springframework.boot:spring-boot-starter-security")
implementation("io.micrometer:micrometer-registry-prometheus")
implementation("org.springdoc:springdoc-openapi-starter-webmvc-ui")

Expand All @@ -29,7 +30,7 @@ dependencies {
implementation(project(":db-migrations"))
implementation("org.liquibase:liquibase-core")
implementation("com.github.blagerweij:liquibase-sessionlock")
implementation("net.ttddyy.observation:datasource-micrometer-spring-boot:1.0.6")
implementation("net.ttddyy.observation:datasource-micrometer-spring-boot:1.1.0")
implementation("net.logstash.logback:logstash-logback-encoder:8.0")

testImplementation("org.springframework.boot:spring-boot-starter-test")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

import io.opentelemetry.exporter.otlp.trace.OtlpGrpcSpanExporter;
import io.opentelemetry.exporter.otlp.trace.OtlpGrpcSpanExporterBuilder;
import org.springframework.boot.actuate.autoconfigure.tracing.otlp.OtlpAutoConfiguration;
import org.springframework.boot.actuate.autoconfigure.tracing.otlp.OtlpProperties;
import org.springframework.boot.actuate.autoconfigure.tracing.otlp.OtlpTracingAutoConfiguration;
import org.springframework.boot.actuate.autoconfigure.tracing.otlp.OtlpTracingProperties;
import org.springframework.boot.autoconfigure.AutoConfigureBefore;
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
import org.springframework.context.annotation.Bean;
Expand All @@ -19,17 +19,17 @@
import java.util.Locale;
import javax.annotation.Nonnull;

@AutoConfigureBefore(OtlpAutoConfiguration.class)
@AutoConfigureBefore(OtlpTracingAutoConfiguration.class)
@Configuration(proxyBeanMethods = false)
class OpenTelemetryConfig {

// Waiting for https://github.com/spring-projects/spring-boot/pull/41213
@Bean
@ConditionalOnMissingBean(OtlpGrpcSpanExporter.class)
OtlpGrpcSpanExporter otelJaegerGrpcSpanExporter(@Nonnull final OtlpProperties otlpProperties) {
OtlpGrpcSpanExporter otelJaegerGrpcSpanExporter(@Nonnull final OtlpTracingProperties otlpProperties) {
final OtlpGrpcSpanExporterBuilder builder = OtlpGrpcSpanExporter.builder()
.setEndpoint(otlpProperties.getEndpoint())
.setTimeout(otlpProperties.getTimeout())
.setConnectTimeout(otlpProperties.getConnectTimeout())
.setCompression(String.valueOf(otlpProperties.getCompression()).toLowerCase(Locale.ROOT));
otlpProperties.getHeaders().forEach(builder::addHeader);
return builder.build();
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/*
* Copyright (c) 2020-2025. Ivan Vakhrushev and others.
* https://github.com/mfvanek/spring-boot-open-telemetry-demo
*
* Licensed under the Apache License 2.0
*/

package io.github.mfvanek.spring.boot3.test.config;

import lombok.SneakyThrows;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
import org.springframework.security.web.SecurityFilterChain;

@Configuration(proxyBeanMethods = false)
public class SecurityConfig {

@Bean
@SneakyThrows

Check warning on line 20 in spring-boot-3-demo-app/src/main/java/io/github/mfvanek/spring/boot3/test/config/SecurityConfig.java

View check run for this annotation

Codecov / codecov/patch

spring-boot-3-demo-app/src/main/java/io/github/mfvanek/spring/boot3/test/config/SecurityConfig.java#L20

Added line #L20 was not covered by tests
public SecurityFilterChain securityFilterChain(HttpSecurity http) {
http.authorizeHttpRequests(authorize ->
authorize.anyRequest().permitAll());
return http.build();
}
}
19 changes: 12 additions & 7 deletions spring-boot-3-demo-app/src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,31 +59,32 @@ management:
server:
port: 8085
endpoints:
enabled-by-default: false
web:
exposure.include: '*'
cors:
allowed-methods: '*'
allowed-origins: '*'
allowed-headers: '*'
access:
default: read_only
endpoint:
health:
enabled: true
probes.enabled: true
group:
readiness:
include: readinessState, db
additional-path: server:/readyz # In order to collect probes from application main port
access: read_only
prometheus:
enabled: true
access: read_only
liquibase:
enabled: true
access: read_only
info:
enabled: true
access: read_only
threaddump:
enabled: true
access: read_only
heapdump:
enabled: true
access: read_only
metrics:
distribution:
percentiles-histogram:
Expand Down Expand Up @@ -111,6 +112,10 @@ management:
- w3c
sampling:
probability: 1.0
observations:
enable:
spring:
security: false
otlp:
tracing:
endpoint: http://localhost:4317
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,13 @@ void contextLoads() {
assertThat(applicationContext.getBean("otelJaegerGrpcSpanExporter"))
.isNotNull()
.isInstanceOf(OtlpGrpcSpanExporter.class)
.hasToString(String.format(Locale.ROOT, "OtlpGrpcSpanExporter{exporterName=otlp, type=span, " +
"endpoint=http://localhost:%d, " +
"endpointPath=/opentelemetry.proto.collector.trace.v1.TraceService/Export, timeoutNanos=5000000000, " +
"connectTimeoutNanos=10000000000, compressorEncoding=null, " +
"headers=Headers{User-Agent=OBFUSCATED}, memoryMode=IMMUTABLE_DATA}", JaegerInitializer.getFirstMappedPort()));
.hasToString(String.format(Locale.ROOT, """
OtlpGrpcSpanExporter{exporterName=otlp, type=span, endpoint=http://localhost:%d, \
endpointPath=/opentelemetry.proto.collector.trace.v1.TraceService/Export, \
timeoutNanos=5000000000, connectTimeoutNanos=10000000000, compressorEncoding=null, \
headers=Headers{User-Agent=OBFUSCATED}, \
retryPolicy=RetryPolicy{maxAttempts=5, initialBackoff=PT1S, maxBackoff=PT5S, backoffMultiplier=1.5}, \
memoryMode=IMMUTABLE_DATA}""", JaegerInitializer.getFirstMappedPort()));
}

@Test
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/*
* Copyright (c) 2020-2025. Ivan Vakhrushev and others.
* https://github.com/mfvanek/spring-boot-open-telemetry-demo
*
* Licensed under the Apache License 2.0
*/

package io.github.mfvanek.spring.boot3.test.controllers;

import io.github.mfvanek.spring.boot3.test.support.TestBase;
import org.junit.jupiter.api.Test;

import static io.github.mfvanek.spring.boot3.test.filters.TraceIdInResponseServletFilter.TRACE_ID_HEADER_NAME;
import static org.assertj.core.api.Assertions.assertThat;

class RedirectControllerTest extends TestBase {

@Test
void redirectShouldWork() {
final Object result = webTestClient.get()
.uri("/redirect")
.exchange()
.expectStatus().isEqualTo(303)
.expectHeader().exists(TRACE_ID_HEADER_NAME)
.expectHeader().location("https://www.google.com")
.expectBody(Object.class)
.returnResult()
.getResponseBody();
assertThat(result)
.isNull();
}
}
Loading