-
Couldn't load subscription status.
- Fork 6
Add example of batch reading from Kafka with context propagation #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I found a checkstyle problem in build, but need some time to solve it as after merging master branch got a Gradle error I tried to reset HEAD then rearrange imports and after that remerge master to fix checkstyle errors, but need some time to fix this error. May be it won't appear in my Linux laptop UPD the problem was with Gradle JVM |
350c693 to
7d35754
Compare
db-migrations/src/main/resources/db/changelog/sql/add_span_column.sql
Outdated
Show resolved
Hide resolved
...in/src/main/kotlin/io/github/mfvanek/spring/boot3/kotlin/test/service/KafkaReadingService.kt
Outdated
Show resolved
Hide resolved
...in/src/main/kotlin/io/github/mfvanek/spring/boot3/kotlin/test/service/KafkaReadingService.kt
Outdated
Show resolved
Hide resolved
...in/src/main/kotlin/io/github/mfvanek/spring/boot3/kotlin/test/service/KafkaReadingService.kt
Outdated
Show resolved
Hide resolved
spring-boot-3-demo-app-kotlin/src/main/resources/application.yml
Outdated
Show resolved
Hide resolved
...src/test/kotlin/io/github/mfvanek/spring/boot3/kotlin/test/controllers/TimeControllerTest.kt
Outdated
Show resolved
Hide resolved
...active/src/main/java/io/github/mfvanek/spring/boot3/reactive/controllers/TimeController.java
Outdated
Show resolved
Hide resolved
...ctive/src/main/java/io/github/mfvanek/spring/boot3/reactive/service/KafkaReadingService.java
Outdated
Show resolved
Hide resolved
...ctive/src/main/java/io/github/mfvanek/spring/boot3/reactive/service/KafkaReadingService.java
Outdated
Show resolved
Hide resolved
db-migrations/src/main/java/io/github/mfvanek/db/migrations/common/saver/DbSaver.java
Show resolved
Hide resolved
...ve/src/test/java/io/github/mfvanek/spring/boot3/reactive/controllers/TimeControllerTest.java
Outdated
Show resolved
Hide resolved
...mo-app/src/test/java/io/github/mfvanek/spring/boot3/test/controllers/TimeControllerTest.java
Outdated
Show resolved
Hide resolved
...t-3-demo-app/src/test/java/io/github/mfvanek/spring/boot3/test/service/KafkaTracingTest.java
Outdated
Show resolved
Hide resolved
...ctive/src/main/java/io/github/mfvanek/spring/boot3/reactive/service/KafkaReadingService.java
Show resolved
Hide resolved
...in/src/main/kotlin/io/github/mfvanek/spring/boot3/kotlin/test/service/KafkaReadingService.kt
Outdated
Show resolved
Hide resolved
...src/test/kotlin/io/github/mfvanek/spring/boot3/kotlin/test/controllers/TimeControllerTest.kt
Outdated
Show resolved
Hide resolved
...ctive/src/main/java/io/github/mfvanek/spring/boot3/reactive/service/KafkaReadingService.java
Outdated
Show resolved
Hide resolved
...ctive/src/main/java/io/github/mfvanek/spring/boot3/reactive/service/KafkaReadingService.java
Outdated
Show resolved
Hide resolved
...ve/src/test/java/io/github/mfvanek/spring/boot3/reactive/controllers/TimeControllerTest.java
Outdated
Show resolved
Hide resolved
...-demo-app/src/main/java/io/github/mfvanek/spring/boot3/test/service/KafkaReadingService.java
Show resolved
Hide resolved
...mo-app/src/test/java/io/github/mfvanek/spring/boot3/test/controllers/TimeControllerTest.java
Outdated
Show resolved
Hide resolved
...demo-app/src/test/java/io/github/mfvanek/spring/boot3/test/service/PublicApiServiceTest.java
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
============================================
+ Coverage 94.24% 96.54% +2.29%
- Complexity 110 135 +25
============================================
Files 39 42 +3
Lines 313 376 +63
Branches 10 8 -2
============================================
+ Hits 295 363 +68
+ Misses 10 7 -3
+ Partials 8 6 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #224
There is a difference between Kotlin and Java modules i.e. in Kotlin app trace ids are equal for single record and batch record listening though in Java apps they are different.
Also I didn't complete the work on increasing test coverage. Lines with forming error spans in KafkaReadingService are not covered. So I wrote a test for a non-reactive Java app, which solves partially this problem (it is KafkaTracingTest), but I am not sure of this one.