-
Notifications
You must be signed in to change notification settings - Fork 0
Update dependency pytest-asyncio to v1 - autoclosed #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Pull Request Review: pytest-asyncio v0.x to v1.x UpgradeOverviewThis PR updates pytest-asyncio from >=0.21.0,<1.0.0 to >=1.2.0,<1.3.0, a major version upgrade with breaking changes. Critical Issue: Breaking Change DetectedThe event_loop fixture has been removed in pytest-asyncio v1.0.0 Your codebase defines a custom event_loop fixture in tests/conftest.py lines 14-19. This will cause issues because:
Required ChangesOption 1 (Recommended): Remove the custom event_loop fixture - delete lines 14-19 in tests/conftest.py Option 2: Use loop_scope configuration in pyproject.toml Positive Aspects
New Features in v1.x
Testing Recommendations
Security and Performance
RecommendationDO NOT MERGE YET - Requires code changes to tests/conftest.py Action Items:
|
b46e35b to
c84f7c4
Compare
Pull Request Review: Update pytest-asyncio to v1.2.0SummaryThis PR updates pytest-asyncio from version <1.0.0 to >=1.2.0,<1.3.0, a major version upgrade that includes breaking changes and new features. Breaking Changes & Issues1. CRITICAL: Deprecated event_loop fixture is being used
Recommended Fix: Remove the custom event_loop fixture from tests/conftest.py (lines 14-19). pytest-asyncio v1.x manages event loops automatically. 2. Async fixturesGood news: I didn't find any async fixtures in your test suite, so you're safe from deprecation warnings. Required Actions Before MergeMUST DO:
SHOULD DO:
Benefits of This Upgrade
Security Considerations
Test Coverage Impact
Code Quality & Best Practices
RecommendationDO NOT MERGE until addressing the critical issue:
Once the fixture is removed and tests pass, this upgrade is highly recommended for the improvements and bug fixes it provides. Review performed by Claude Code following CLAUDE.md guidelines. |
c84f7c4 to
46473dc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #42 +/- ##
========================================
Coverage 27.48% 27.48%
========================================
Files 31 31
Lines 2965 2965
========================================
Hits 815 815
Misses 2150 2150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Review: pytest-asyncio v1.2.0 UpgradeSummaryThis PR upgrades Code Quality & Best Practices
|
This PR contains the following updates:
>=0.21.0,<1.0.0->>=1.2.0,<1.3.0Release Notes
pytest-dev/pytest-asyncio (pytest-asyncio)
v1.2.0: pytest-asyncio 1.2.0Compare Source
1.2.0 - 2025-09-12
Added
--asyncio-debugCLI option andasyncio_debugconfiguration option to enable asyncio debug mode for the default event loop. (#980)pytest.UsageErrorfor invalid configuration values ofasyncio_default_fixture_loop_scopeandasyncio_default_test_loop_scope. (#1189)Fixed
RuntimeError: There is no current event loop in thread 'MainThread'when any test unsets the event loop (such as when usingasyncio.runandasyncio.Runner). (#1177)@pytest.fixturein [strict]{.title-ref} mode. The warning message now refers to the correct package. (#1198)Notes for Downstream Packagers
tox.inifile provided by pytest-asyncio to run tests.v1.1.1: pytest-asyncio 1.1.1Compare Source
v1.1.1 - 2025-09-12
Notes for Downstream Packagers
- Addresses a build problem with setuptoos-scm >= 9 caused by invalid setuptools-scm configuration in pytest-asyncio. (#1192)
v1.1.0: pytest-asyncio 1.1.0Compare Source
Added
loop_scopeends (#200)Fixed
finallyclause of a task (#878)Notes for Downstream Packagers
v1.0.0: pytest-asyncio 1.0.0Compare Source
1.0.0 - 2025-05-26
Removed
(#1106)
Added
(#1025)
Changed
than per scope (e.g. per module). This reduces the number of fixtures
and speeds up collection time, especially for large test suites.
(#1107)
pytest.mark.asynciono longer forcesthat a pytest Collector exists at the level of the specified scope.
For example, a test function marked with
pytest.mark.asyncio(loop_scope="class")no longer requires a classsurrounding the test. This is consistent with the behavior of the
scope argument to
pytest_asyncio.fixture.(#1112)
Fixed
option.
(#630)
--doctest-ignore-import-errors(#797)
(#1052)
Notes for Downstream Packagers
(#1114)
v0.26.0: pytest-asyncio 0.26.0Compare Source
pytest_asyncio.fixture#1045typing-extensionsas additional dependency for Python<3.10#1045v0.25.3: pytest-asyncio 0.25.3Compare Source
v0.25.2: pytest-asyncio 0.25.2Compare Source
loop.shutdown_asyncgens()before closing the event loop to ensure async generators are closed in the same manner asasyncio.rundoes #1034v0.25.1: pytest-asyncio 0.25.1Compare Source
v0.25.0: pytest-asyncio 0.25.0Compare Source
0.25.0 (2024-12-13)
@pytest.fixturein strict mode. This will become an error in a future version of flake8-asyncio. #979v0.24.0: pytest-asyncio 0.24.0Compare Source
0.24.0 (2024-08-22)
pytest_asyncio.fixture. Users are encouraged to use the loop_scope keyword argument, which does exactly the same.@pytest.mark.asyncio. #812Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.