Better static scope checks for \Drupal static calls (#581)

Author: mglaman

src/Rules/Drupal/GlobalDrupalDependencyInjectionRule.php

@@ -4,9 +4,8 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
-use PHPStan\Reflection\MethodReflection;
+use PHPStan\Reflection\ExtendedMethodReflection;
 use PHPStan\Rules\Rule;
-use PHPStan\ShouldNotHappenException;
 
 class GlobalDrupalDependencyInjectionRule implements Rule
 {
@@ -23,7 +22,7 @@ public function processNode(Node $node, Scope $scope): array
         if (!($node->class instanceof Node\Name\FullyQualified) || (string) $node->class !== 'Drupal') {
             return [];
         }
-        // Do not raise if called inside of a trait.
+        // Do not raise if called inside a trait.
         if (!$scope->isInClass() || $scope->isInTrait()) {
             return [];
         }
@@ -60,15 +59,13 @@ public function processNode(Node $node, Scope $scope): array
             }
         }
 
-        if ($scope->getFunctionName() === null) {
-            throw new ShouldNotHappenException();
-        }
-
         $scopeFunction = $scope->getFunction();
-        if (!($scopeFunction instanceof MethodReflection)) {
-            throw new ShouldNotHappenException();
+        if ($scopeFunction === null) {
+            return [];
+        }
+        if (!$scopeFunction instanceof ExtendedMethodReflection) {
+            return [];
         }
-        // Static methods have to invoke \Drupal.
         if ($scopeFunction->isStatic()) {
             return [];
         }

tests/src/Rules/GlobalDrupalDependencyInjectionRuleTest.php

@@ -58,6 +58,11 @@ public function resultData(): \Generator
             [],
         ];
 
+        yield [
+            __DIR__ . '/data/bug-580.php',
+            [],
+        ];
+
         if (PHP_VERSION_ID >= 80100) {
             yield [
                 __DIR__ . '/data/bug-500.php',

tests/src/Rules/data/bug-580.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Bug580;
+
+class Foo {
+    public function bar() {
+        function baz() {
+            \Drupal::a();
+        }
+    }
+}