Merge pull request #313 from mglaman/gh303

Allow non-callable in #lazy_builder if array_intersect_key

Author: mglaman

src/Rules/Drupal/RenderCallbackRule.php

@@ -4,6 +4,7 @@
 
 use mglaman\PHPStanDrupal\Drupal\ServiceMap;
 use PhpParser\Node;
+use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
@@ -18,8 +19,11 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\ThisType;
 use PHPStan\Type\Type;
+use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\UnionType;
 use PHPStan\Type\VerbosityLevel;
+use Drupal\Core\Render\PlaceholderGeneratorInterface;
+use Drupal\Core\Render\RendererInterface;
 
 final class RenderCallbackRule implements Rule
 {
@@ -62,6 +66,23 @@ public function processNode(Node $node, Scope $scope): array
 
         // @todo Move into its own rule.
         if ($keyChecked === '#lazy_builder') {
+            // Check if being used in array_intersect_key.
+            // NOTE: This only works against existing patterns in Drupal core where the array with boolean values is
+            // being passed as the argument to array_intersect_key.
+            $parent = $node->getAttribute('parent');
+            if ($parent instanceof Node\Expr\Array_) {
+                $parent = $parent->getAttribute('parent');
+                if ($parent instanceof Node\Arg) {
+                    $parent = $parent->getAttribute('parent');
+                    if ($parent instanceof Node\Expr\FuncCall
+                        && $parent->name instanceof Name
+                        && $parent->name->toString() === 'array_intersect_key'
+                    ) {
+                        return [];
+                    }
+                }
+            }
+
             if (!$value instanceof Node\Expr\Array_) {
                 return [
                     RuleErrorBuilder::message(sprintf('The "%s" expects a callable array with arguments.', $keyChecked))
@@ -118,7 +139,7 @@ private function doProcessNode(Node\Expr $node, Scope $scope, string $keyChecked
             }
             // We can determine if the callback is callable through the type system. However, we cannot determine
             // if it is just a function or a static class call (MyClass::staticFunc).
-            if ($this->reflectionProvider->hasFunction(new Node\Name($type->getValue()), null)) {
+            if ($this->reflectionProvider->hasFunction(new Name($type->getValue()), null)) {
                 return RuleErrorBuilder::message(
                     sprintf("%s callback %s at key '%s' is not trusted.", $keyChecked, $type->describe(VerbosityLevel::value()), $pos)
                 )->line($errorLine)

tests/src/Rules/PreRenderCallbackRuleTest.php

@@ -100,6 +100,14 @@ public function fileData(): \Generator
             __DIR__ . '/../../fixtures/drupal/core/lib/Drupal/Core/Access/RouteProcessorCsrf.php',
             []
         ];
+        yield [
+            __DIR__ . '/../../fixtures/drupal/core/lib/Drupal/Core/Render/PlaceholderGenerator.php',
+            []
+        ];
+        yield [
+            __DIR__ . '/../../fixtures/drupal/core/lib/Drupal/Core/Render/Renderer.php',
+            []
+        ];
     }