Verify service mapping works, but deprecations are not caught

Author: mglaman

tests/fixtures/drupal/modules/phpstan_fixtures/src/UsesDeprecatedServiceMethod.php renamed to tests/fixtures/drupal/modules/phpstan_fixtures/src/TestServicesMappingExtension.php

@@ -4,10 +4,11 @@
 
 use Drupal\Core\Entity\EntityManager;
 
-class UsesDeprecatedServiceMethod {
+class TestServicesMappingExtension {
     public function test() {
         $entity_manager = \Drupal::getContainer()->get('entity.manager');
-        // Deprecated for EntityTypeManagerInterface::getDefinitions().
+        $doesNotExist = $entity_manager->thisMethodDoesNotExist();
+        // @todo this should be throwing deprecations...
         $definitions = $entity_manager->getDefinitions();
     }
 }

tests/src/DeprecationRulesTest.php

@@ -47,13 +47,5 @@ public function dataDeprecatedSamples(): \Generator
                 'Call to deprecated constant DATETIME_DATE_STORAGE_FORMAT: Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use \Drupal\datetime\Plugin\Field\FieldType\DateTimeItemInterface::DATE_STORAGE_FORMAT instead.',
             ]
         ];
-        yield [
-            __DIR__ . '/../fixtures/drupal/modules/phpstan_fixtures/src/UsesDeprecatedServiceMethod.php',
-            2,
-            [
-                '\Drupal calls should be avoided in classes, use dependency injection instead',
-                'Call to deprecated method getDefinitions() of class',
-            ]
-        ];
     }
 }

tests/src/DrupalIntegrationTest.php

@@ -34,4 +34,15 @@ public function testExtensionReportsError() {
         $this->assertEquals('Function phpstan_fixtures_MissingReturnRule() should return string but return statement is missing.', $errors[0]->getMessage());
     }
 
+    public function testServiceMapping() {
+        $errorMessages = [
+            '\Drupal calls should be avoided in classes, use dependency injection instead',
+            'Call to an undefined method Drupal\Core\Entity\EntityManager::thisMethodDoesNotExist().',
+        ];
+        $errors = $this->runAnalyze(__DIR__ . '/../fixtures/drupal/modules/phpstan_fixtures/src/TestServicesMappingExtension.php');
+        $this->assertCount(2, $errors);
+        foreach ($errors as $key => $error) {
+            $this->assertEquals($errorMessages[$key], $error->getMessage());
+        }
+    }
 }