Skip to content

Reduce gem size by excluding test files #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fwininger merged 4 commits into from
Mar 7, 2026
Merged

Reduce gem size by excluding test files #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49508ea
Reduce gem size by excluding test files
yuri-zubov Mar 6, 2026
8137e38
Adds Version
yuri-zubov Mar 6, 2026
ca04561
Fixed rubocop
yuri-zubov Mar 6, 2026
f4f6631
Fixes Rubocop rule (Style/OneClassPerFile)
yuri-zubov Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions api_auth.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ Gem::Specification.new do |s|
s.add_development_dependency 'rubocop', '~> 1.50'
s.add_development_dependency 'typhoeus', '~> 1.4'

s.files = `git ls-files`.split("\n")
Copy link
Collaborator

@fwininger fwininger Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May add api_auth.gemspec and VERSION

Copy link
Contributor Author

@yuri-zubov yuri-zubov Mar 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api_auth.gemspec is not necessary
Added VERSION

Copy link
Contributor Author

@yuri-zubov yuri-zubov Mar 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fwininger
The same MR in the popular gem friendly_id

https://github.com/rgrove/sanitize/pull/248/changes
No one adds gemspec

s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
s.files = `git ls-files lib`.split("\n") + ['LICENSE.txt', 'CHANGELOG.md', 'README.md', 'VERSION']
s.require_paths = ['lib']
end
3 changes: 2 additions & 1 deletion lib/api_auth/request_drivers/rest_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# give access to RestClient @processed_headers
module RestClient; class Request; attr_accessor :processed_headers; end; end

require_relative '../../rest_client/request_patch'

module ApiAuth
module RequestDrivers # :nodoc:
Expand Down
6 changes: 6 additions & 0 deletions lib/rest_client/request_patch.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module RestClient
# Adds accessor for processed_headers used by ApiAuth.
class Request
attr_accessor :processed_headers
end
end