adodbapi: improve module docstrings, top-of-file comments and version infos#2347
adodbapi: improve module docstrings, top-of-file comments and version infos#2347Avasam wants to merge 12 commits intomhammond:mainfrom
Conversation
Avasam
force-pushed
the
adodbapi--improve-docstrings-and-top-of-file-comments
branch
from
c237be5 to
9157292
Compare
Avasam
changed the title
Avasam
force-pushed
the
adodbapi--improve-docstrings-and-top-of-file-comments
branch
from
8355561 to
4cf15f9
Compare
…api--improve-docstrings-and-top-of-file-comments
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
Can we future proof this a little more? tbh, just removing it seems fine, we don't feel the need to make this declaration for any other package - I think reasonable people would assume it is supported by all Python versions supported by the repo.
adodbapi/setup.py
Outdated
| """adodbapi - a pure Python PEP 249 DB-API package using Microsoft ADO | ||
|
|
||
| Adodbapi can be run on CPython 3.8 and later. | ||
| Adodbapi can be run on CPython 3.9 and later. |
There was a problem hiding this comment.
@mhammond did you mean to aim the following comment at this file/line?
Can we future proof this a little more? tbh, just removing it seems fine, we don't feel the need to make this declaration for any other package - I think reasonable people would assume it is supported by all Python versions supported by the repo.
If so, I agree. Anyway as long as adodbapi is distributed by pywin32, this setuptools config file goes pretty much unused (though it is usable, by running pip install ./adodbapi).
And even if adodbapi was to be distributed as its own distribution on PyPI, it would be better declared through packaging metadata.
| Adodbapi can be run on CPython 3.9 and later. |
…api--improve-docstrings-and-top-of-file-comments
…api--improve-docstrings-and-top-of-file-comments
2 participants
@vernondcole Pretty safe PR affecting documentation and will reduce changes in other PRs as well.