Stop using (exposing) deprecated Py_FrozenFlag
#2593
+54
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Stop-using-Py_FrozenFlag
branch
from
55b81a3 to
733d865
Compare
Avasam
commented
Apr 30, 2025
|
|
||
| if addPyComCat is None: | ||
| addPyComCat = pythoncom.frozen == 0 | ||
| addPyComCat = __frozen == False |
There was a problem hiding this comment.
I would've done
Suggested change
| addPyComCat = __frozen == False | |
| addPyComCat = not __frozen |
But since pythoncom.frozen = sys.frozen, and we see above that sys.frozen could be "dll". "dll" != 0.
I don't know if this was an oversight or intended behaviour, so I kept the current behaviour.
Avasam
force-pushed
the
Stop-using-Py_FrozenFlag
branch
2 times, most recently
from
f5f985d to
eaea420
Compare
Avasam
commented
Apr 30, 2025
Comment on lines
+9
to
+13
| # This module dynamically re-exports from a C-Extension. | ||
| # `__getattr__() -> Any` prevents checkers attribute access errors | ||
| # without the use of external type stubs. | ||
| # So keep it even if pythoncom.frozen support is removed. | ||
| def __getattr__(name: str) -> Any: |
There was a problem hiding this comment.
This incidentally has the exact same benefits as https://github.com/mhammond/pywin32/pull/2418/files#diff-417d6662c94f9f97ab29ec3611822c62e6da513054d38f6dfdc0155fc2f4463b
(which does:
from typing import TYPE_CHECKING, Any
if TYPE_CHECKING:
def __getattr__(name: str) -> Any: ...)
Avasam
force-pushed
the
Stop-using-Py_FrozenFlag
branch
from
eaea420 to
c3b7b17
Compare
Avasam
force-pushed
the
Stop-using-Py_FrozenFlag
branch
from
c3b7b17 to
4e6f444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to stop using
Py_FrozenFlag, solving one of the C API deprecation in #2588The initial version of this PR does so by deprecating
pythoncom.frozenin favor ofgetattr(sys, "frozen", False).This is mainly motivated by the side-effect hack importing
win32comdoes onpythoncom.frozen.An alternative is to give more utility to
pythoncom.frozenby officially making it a wrapper togetattr(sys, "frozen", False)allowing users to simply usepythoncom.frozeninstead of messing withgetattrthemselves. But I think it's fair to ask if it's pywin32's job to offer a helper property-like attribute to an optionalsysattribute unrelated to Windows ? (if pywin32 uses its own helper though, that's fine).