perf(browsers): replace execSync with async version detection

src/core/browsers/BrowserAvailability.ts

@@ -3,13 +3,13 @@
  * @module BrowserAvailability
  */
 
-import { execSync } from "node:child_process";
 import { existsSync, readdirSync } from "node:fs";
 import { homedir } from "node:os";
 import { join } from "node:path";
 
 import { createTaggedLogger } from "@utils/logHelpers";
 import { getPlatform, isLinux, isMacOS, isWindows } from "@utils/platformUtils";
+import { execSimple } from "@utils/execSimple";
 
 import { getBrowserDisplayName } from "./BrowserDetector";
 import type { BrowserType } from "./BrowserDetector";
@@ -290,55 +290,70 @@ function checkBrowserInstalled(browser: BrowserType): boolean {
 }
 
 /**
- * Gets the version of an installed browser
+ * Gets the version command for a browser on the current platform
+ * @param browser - The browser type
+ * @returns Shell command to get browser version, or undefined
+ */
+function getVersionCommand(browser: BrowserType): string | undefined {
+  if (isMacOS()) {
+    const versionCommands: Partial<Record<BrowserType, string>> = {
+      chrome:
+        "/Applications/Google\\ Chrome.app/Contents/MacOS/Google\\ Chrome --version 2>/dev/null",
+      firefox:
+        "/Applications/Firefox.app/Contents/MacOS/firefox --version 2>/dev/null",
+      safari:
+        "defaults read /Applications/Safari.app/Contents/Info.plist CFBundleShortVersionString 2>/dev/null",
+      edge: "/Applications/Microsoft\\ Edge.app/Contents/MacOS/Microsoft\\ Edge --version 2>/dev/null",
+      arc: "defaults read /Applications/Arc.app/Contents/Info.plist CFBundleShortVersionString 2>/dev/null",
+      brave:
+        "/Applications/Brave\\ Browser.app/Contents/MacOS/Brave\\ Browser --version 2>/dev/null",
+      opera:
+        "/Applications/Opera.app/Contents/MacOS/Opera --version 2>/dev/null",
+      "opera-gx":
+        "/Applications/Opera\\ GX.app/Contents/MacOS/Opera\\ GX --version 2>/dev/null",
+      vivaldi:
+        "/Applications/Vivaldi.app/Contents/MacOS/Vivaldi --version 2>/dev/null",
+    };
+    return versionCommands[browser];
+  }
+
+  if (isLinux()) {
+    const versionCommands: Partial<Record<BrowserType, string>> = {
+      chrome:
+        "google-chrome --version 2>/dev/null || google-chrome-stable --version 2>/dev/null",
+      firefox: "firefox --version 2>/dev/null",
+      edge: "microsoft-edge --version 2>/dev/null",
+      brave:
+        "brave-browser --version 2>/dev/null || brave-browser-stable --version 2>/dev/null",
+      opera: "opera --version 2>/dev/null",
+      "opera-gx": "opera-gx --version 2>/dev/null",
+      vivaldi:
+        "vivaldi --version 2>/dev/null || vivaldi-stable --version 2>/dev/null",
+    };
+    return versionCommands[browser];
+  }
+
+  // Windows version detection is more complex, skip for now
+  return undefined;
+}
+
+/**
+ * Gets the version of an installed browser asynchronously
  * @param browser - The browser type
  * @returns The browser version or undefined
  */
-function getBrowserVersion(browser: BrowserType): string | undefined {
+export async function getBrowserVersionAsync(
+  browser: BrowserType,
+): Promise<string | undefined> {
   try {
-    let command: string | undefined;
-
-    if (isMacOS()) {
-      const versionCommands: Partial<Record<BrowserType, string>> = {
-        chrome:
-          "/Applications/Google\\ Chrome.app/Contents/MacOS/Google\\ Chrome --version 2>/dev/null",
-        firefox:
-          "/Applications/Firefox.app/Contents/MacOS/firefox --version 2>/dev/null",
-        safari:
-          "defaults read /Applications/Safari.app/Contents/Info.plist CFBundleShortVersionString 2>/dev/null",
-        edge: "/Applications/Microsoft\\ Edge.app/Contents/MacOS/Microsoft\\ Edge --version 2>/dev/null",
-        arc: "defaults read /Applications/Arc.app/Contents/Info.plist CFBundleShortVersionString 2>/dev/null",
-        brave:
-          "/Applications/Brave\\ Browser.app/Contents/MacOS/Brave\\ Browser --version 2>/dev/null",
-        opera:
-          "/Applications/Opera.app/Contents/MacOS/Opera --version 2>/dev/null",
-        "opera-gx":
-          "/Applications/Opera\\ GX.app/Contents/MacOS/Opera\\ GX --version 2>/dev/null",
-        vivaldi:
-          "/Applications/Vivaldi.app/Contents/MacOS/Vivaldi --version 2>/dev/null",
-      };
-      command = versionCommands[browser];
-    } else if (isLinux()) {
-      const versionCommands: Partial<Record<BrowserType, string>> = {
-        chrome:
-          "google-chrome --version 2>/dev/null || google-chrome-stable --version 2>/dev/null",
-        firefox: "firefox --version 2>/dev/null",
-        edge: "microsoft-edge --version 2>/dev/null",
-        brave:
-          "brave-browser --version 2>/dev/null || brave-browser-stable --version 2>/dev/null",
-        opera: "opera --version 2>/dev/null",
-        "opera-gx": "opera-gx --version 2>/dev/null",
-        vivaldi:
-          "vivaldi --version 2>/dev/null || vivaldi-stable --version 2>/dev/null",
-      };
-      command = versionCommands[browser];
-    } else if (isWindows()) {
-      // Windows version detection is more complex, skip for now
+    const command = getVersionCommand(browser);
+    if (command === undefined) {
       return undefined;
     }
 
-    if (command !== undefined) {
-      const version = execSync(command, { encoding: "utf8" }).trim();
+    const { stdout } = await execSimple(command);
+    const version = stdout.trim();
+    if (version) {
       logger.debug("Got browser version", { browser, version });
       return version;
     }
@@ -476,12 +491,10 @@ function findBrowserProfiles(browser: BrowserType): string[] {
 }
 
 /**
- * Detects all available browsers on the current system
- *
- * Note: This function is intentionally synchronous. All file system operations
- * (existsSync, readdirSync) are synchronous, and all callers use this function
- * synchronously. No async/await patterns are used anywhere in the codebase.
- *
+ * Detects all available browsers on the current system.
+ * This function is synchronous — it checks file system paths only.
+ * Browser version detection is async and available separately via
+ * {@link getBrowserVersionAsync}.
  * @returns Array of available browser information
  */
 export function detectAvailableBrowsers(): AvailableBrowser[] {
@@ -510,14 +523,8 @@ export function detectAvailableBrowsers(): AvailableBrowser[] {
         profilePaths: findBrowserProfiles(browser),
       };
 
-      const version = getBrowserVersion(browser);
-      if (version !== undefined) {
-        info.version = version;
-      }
-
       logger.info("Found available browser", {
         browser: info.name,
-        version: info.version,
         profiles: info.profilePaths?.length ?? 0,
       });
 
@@ -535,7 +542,8 @@ export function detectAvailableBrowsers(): AvailableBrowser[] {
 }
 
 /**
- * Gets detailed information about a specific browser
+ * Gets detailed information about a specific browser.
+ * Version is not included — use {@link getBrowserVersionAsync} separately if needed.
  * @param browser - The browser type
  * @returns Browser information or undefined if not available
  */
@@ -548,19 +556,12 @@ export function getBrowserInfo(
     return undefined;
   }
 
-  const result: AvailableBrowser = {
+  return {
     type: browser,
     name: getBrowserDisplayName(browser),
     installed: true,
     profilePaths: findBrowserProfiles(browser),
   };
-
-  const version = getBrowserVersion(browser);
-  if (version !== undefined) {
-    result.version = version;
-  }
-
-  return result;
 }
 
 /**