Allow PHP 8.0 #11
Merged
Allow PHP 8.0 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If we want to use php 8.0 then we need to use phpunit 9. But then we loose support for php 7.2 ;( What is your opinion folks? |
Contributor
Author
|
PHP 8 travis build will work after new https://github.com/consistence/coding-standard release (consistence/coding-standard#65) |
It will start working when schmittjoh/JMSSerializerBundle#819 will be resolved and released
Owner
|
@ahilles107 Hi! Thanks for the PR. I have dropped support for PHP < 7.4 in a separate PR #12. I've rebased your PR on my changes and added 8.0 to allowed failures (it will fail until the consistence/coding-standard is made compatible). But this library itself works fine on 8.0 (I ran the tests locally) |
Owner
|
@ahilles107 tagged as 3.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.