Skip to content

Conversation

pavlelee
Copy link

@pavlelee pavlelee commented Mar 23, 2022

Issue Number / Link: No

Summary of the issue:

If a directory in a project is called constructor, Commit Detail View always show loading.

Description outlining how this pull request resolves the issue:

normal directory:
wecom-temp-2906404db59352c0d3af4970639f575a

wrong directory:
wecom-temp-c7238f180e89d58b3c9942008bfaee2a
wecom-temp-e06f45d2280e4e1698ff14bb90e1de61

because constructor and JS constructor have the same name:
wecom-temp-f4f09d961f5262a7f7bacc2c5cc467d9

After modification:
image
image

@pavlelee pavlelee requested a review from mhutchie as a code owner March 23, 2022 10:47
@pavlelee pavlelee force-pushed the fix/create-file-tree-error-with-constructor branch from 27f4330 to ca732b5 Compare March 23, 2022 10:55
@pavlelee pavlelee force-pushed the fix/create-file-tree-error-with-constructor branch from ca732b5 to 9f81963 Compare March 23, 2022 10:57
@maxisam
Copy link

maxisam commented Nov 26, 2024

probably should use !Object.prototype.hasOwnProperty.call(cur.contents, path[j])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants