Calculate tilt depends on the device plan#2
Open
sksarojkumar wants to merge 1 commit intomia-recki:mainfrom
Open
Calculate tilt depends on the device plan#2sksarojkumar wants to merge 1 commit intomia-recki:mainfrom
sksarojkumar wants to merge 1 commit intomia-recki:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this works perfectly when the mobile device is parallel to the ground/flat on a table, but when you hold your mobile in your hand it's upward(standing upward 'Portrait') at that time it does not give you correct tilt angles.
I have added that part of the calculation, so, now it will work and give correct tilt angles when you hold your mobile upward.
I have added one variable named 'devicePlan' which takes a value of either 0 or 1.
When a value is 0, it works as works previously and when a value is 1 it works in the upward position.
Some packages are outdated and causing errors so I updated whatever required.
If anything else is required to update or modify please reply to me.