Fixed multiword city names causing a ValueError

[ussjoin]

Description

Replaced the (elegant) replace-and-split line2 line with a less-elegant set of lines that additionally handle multiword city names.

Fixes #38

Type of change

• Bug fix

How has this been tested?

from callsignlookuptools import CallookSyncClient, CallsignLookupError

callook_lookup = CallookSyncClient()

for callsign in ["W3UNX","WB0BK","KJ7ZHG","NA6JD","W9BLN","AK6FK","K1FIE", "W1AW"]:
  lookup_result = callook_lookup.search(callsign)
  print(lookup_result.address.city)

Test cases chosen because (except for W1AW, which is just there for a one-word control) these were some of the callsigns I was getting crashes on, when building a "send my giant pile of QSOs at once" tool for my ham radio club's pro-vaccine event. Had I gotten off my butt and tried to send the QSL cards in a more timely fashion, I would have submitted this bugfix earlier, so my apologies for that.

Checklist

• Issue exists for PR
• Code reviewed by the author
• Code documented (comments or other documentation)
• Changes tested
• All tests pass (see DEVELOPING.md, if it exists)
• CHANGELOG.md updated if needed (I don't think this merits a CHANGELOG notice)
• Informative commit messages
• Descriptive PR title

[classabbyamp]

how about:

zip, state, *city = model_data.address.line2.replace(",", "").split(" ")[::-1]
city = " ".join(city[::-1])

[ussjoin]

@classabbyamp Well, today I learned a new operator (or rather, learned that the colon slicing operator can be a three-part syntax). Thank you! My test code shown in the description confirms your code works as well as mine, so I've updated the MR with your suggestion.

[thadigus]

@ussjoin Thanks for your fix! Do we know if this repo is still maintained? We're having the same issue over here in Van Wert, Ohio!

[classabbyamp]

still maintained, just busy. will try to apply this patch soon

[thadigus]

Awesome, the W8FY club thanks you very much for maintaining such a helpful tool for our community @classabbyamp

[classabbyamp]

squashed and rebased to run CI

[classabbyamp]

released in 1.1.2: https://pypi.org/project/callsignlookuptools/

[ussjoin]

Thank you very much @classabbyamp!