Provide sync support #119
Open
Provide sync support #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The reason why Node.js 4 is failing is unclear. As far as I can see is that the build issue exists for more than 2 years. It has nothing to do with this feature. |
MaheshZ
reviewed
Jul 23, 2020
| var file | ||
|
|
||
| if (options.sync) { | ||
| return composePlugins(handleResult(config('postcss', options).load(path))) |
There was a problem hiding this comment.
config is still asycn i tried running this code should we use sync api instead?
https://github.com/davidtheclark/cosmiconfig#synchronous-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This feature is needed to provide a sync interface for libraries like:
Types of changes
What types of changes does your code introduce
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is a reminder of what we are going to look for before merging your code.