Fix issues with path resolving and listing files #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobko
approved these changes
Dec 19, 2020
When we read files by their number, we never get the right result. For example, we have the following file system structure: folder1/ - subfolder1/ --- file1 --- file2 - file3 - file4 folder2/ - subfolder2/ --- file5 --- file6 - file5 and maxAmountOfFiles = 3, then we will read [folder1, subfolder1, file3, file3, folder2, subfolder2, file5]. And this is not expected result. It is better to read by depth, which will give the expected result.
volodymyrpoli
force-pushed
the
master
branch
from
665de27 to
35837f2
Compare
xaviered
reviewed
Apr 22, 2021
|
|
||
| ```bash | ||
| composer require simpleenergy/php-webhdfs | ||
| composer require dreamfactory/php-webhdfs |
Collaborator
There was a problem hiding this comment.
Changes look good, but I think we should still keep the original package name. I'll be glad to merge your changes as a new version if you remove this.
xaviered
reviewed
Apr 22, 2021
| @@ -1,9 +1,15 @@ | |||
| { | |||
| "name": "simpleenergy/php-webhdfs", | |||
| "name": "dreamfactory/php-webhdfs", | |||
Collaborator
There was a problem hiding this comment.
and of course this one too
xaviered
reviewed
Apr 22, 2021
| "name": "dreamfactory/php-webhdfs", | ||
| "description": "PHP WebHDFS, forked from https://github.com/simpleenergy/php-WebHDFS", | ||
| "minimum-stability": "stable", | ||
| "repositories": [ |
- Get rid of invalid 'CURLINFO_EFFECTIVE_URL' cURL option - Get rid of improper 'Content-Length' HTTP header - Remove version composer`s property, as it should be omitted relying on the documentation https://getcomposer.org/doc/04-schema.md#version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.