Added optional parameter $DIRECTORY_SEPARATOR to split function to address a possible issue in Windows environments.

Author: michaeldrennen

composer.json

@@ -6,10 +6,9 @@
     "php": "^7.3"
   },
   "require-dev": {
-    "mikey179/vfsstream": "dev-master",
-    "phpunit/phpunit": "^8.0",
-    "php-coveralls/php-coveralls": "^2.1"
-
+    "mikey179/vfsstream": "^1.6",
+    "phpunit/phpunit": "^9.5",
+    "php-coveralls/php-coveralls": "^2.4"
   },
   "license": "MIT",
   "authors": [
@@ -18,7 +17,7 @@
       "email": "[email protected]"
     }
   ],
-  "minimum-stability": "alpha",
+  "minimum-stability": "stable",
   "autoload": {
     "psr-4": {
       "MichaelDrennen\\LocalFile\\": "src"

src/LocalFile.php

@@ -35,20 +35,25 @@ public static function lineCount( string $filePath ): int {
     }
 
 
+
     /**
-     * @param string      $pathToSourceFile
-     * @param int         $linesPerFile
-     * @param string      $prefix
+     * @param string $pathToSourceFile
+     * @param int $linesPerFile
+     * @param string|null $prefix
      * @param string|null $destinationPath
-     *
-     * @returns array An array of the paths to the split files.
-     * @throws \MichaelDrennen\LocalFile\Exceptions\CantWriteToReadOnlyDirectory
-     * @throws \MichaelDrennen\LocalFile\Exceptions\SourceFileDoesNotExist
-     * @throws \MichaelDrennen\LocalFile\Exceptions\UnableToReadFile
-     * @throws \MichaelDrennen\LocalFile\Exceptions\UnableToOpenSplitFileHandle
-     * @throws \MichaelDrennen\LocalFile\Exceptions\UnableToWriteLineToSplitFile
+     * @param string $DIRECTORY_SEPARATOR
+     * @return array An array of the paths to the split files.
+     * @throws CantWriteToReadOnlyDirectory
+     * @throws SourceFileDoesNotExist
+     * @throws UnableToOpenSplitFileHandle
+     * @throws UnableToReadFile
+     * @throws UnableToWriteLineToSplitFile
      */
-    public static function split( string $pathToSourceFile, $linesPerFile = 1000, string $prefix = null, string $destinationPath = null ): array {
+    public static function split( string $pathToSourceFile,
+                                  $linesPerFile = 1000,
+                                  string $prefix = null,
+                                  string $destinationPath = null,
+                                  string $DIRECTORY_SEPARATOR = DIRECTORY_SEPARATOR): array {
 
         if ( false === file_exists( $pathToSourceFile ) ):
             throw new SourceFileDoesNotExist( "Can't split [" . $pathToSourceFile . "] because it doesn't exist." );
@@ -75,8 +80,8 @@ public static function split( string $pathToSourceFile, $linesPerFile = 1000, st
         /**
          * Make sure there is a trailing DIRECTORY_SEPARATOR
          */
-        if ( DIRECTORY_SEPARATOR != substr( $destinationPath, -1 ) ):
-            $destinationPath .= DIRECTORY_SEPARATOR;
+        if ( $DIRECTORY_SEPARATOR != substr( $destinationPath, -1 ) ):
+            $destinationPath .= $DIRECTORY_SEPARATOR;
         endif;
 
         if ( false === is_writeable( $destinationPath ) ):
@@ -90,7 +95,6 @@ public static function split( string $pathToSourceFile, $linesPerFile = 1000, st
 
         while ( false !== ( $line = fgets( $sourceHandle ) ) ):
 
-
             $line = trim( $line );
 
             // process the line read.