Skip to content

fix: Chunk fetch method, performance, memory usage #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Chunk fetch method, performance, memory usage #83

wants to merge 1 commit into from

Conversation

Bartek20
Copy link

  • use SoftDeletes trait directly in Cascade trait to fix missing SoftDeletes if user forgots to implement it on model level
  • Fix chunk fetch method
  • Add option to sync timestamps across all relations ($syncTimestamp on model) - makes it easier to implement cascade restore
  • Delete without events if no relations present
  • Fetch only primary key to decrease memory usage

fixes: #76

@Bartek20
Update CascadeSoftDeletes.php
7f90e51 
* use SoftDeletes trait directly in Cascade trait to fix missing SoftDeletes if user forgots to implement it on model level
* Fix chunk fetch method
* Add option to sync timestamps across all relations
* Delete without events if no relations present
* Fetch only primary key to decrease memory usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method Illuminate\Database\Eloquent\Collection::delete does not exist
1 participant
@Bartek20